Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What changed in v2.5.0? #177

Open
NoelDeMartin opened this issue Dec 26, 2020 · 0 comments
Open

What changed in v2.5.0? #177

NoelDeMartin opened this issue Dec 26, 2020 · 0 comments

Comments

@NoelDeMartin
Copy link

I've noticed that the bundle size increased significantly in v2.5.0. I didn't find any impactful change looking at the commits, so I'm not sure whether to update it or continue using the old version.

It seems like the package is tree-shakeable, but given that the API depends on a god object it doesn't benefit from it. For example, I don't use the login popup in my apps but it's being included in my bundles (I'm not sure how much of the total size that is).

Besides looking at the weight on npm, I've tried to compare the impact in my apps changing this dependency, and v2.4.1 was 34.63KiB vs 220.06KiB from v2.5.4.

Is there anything important in that, or should I continue using v2.4.1?

NoelDeMartin added a commit to NoelDeMartin/ramen that referenced this issue Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant