Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Buffer constructor #409

Open
gabrielschulhof opened this issue Aug 28, 2018 · 1 comment
Open

Replace Buffer constructor #409

gabrielschulhof opened this issue Aug 28, 2018 · 1 comment

Comments

@gabrielschulhof
Copy link

new Buffer(...) is deprecated and unsafe. Could it be replaced with Buffer.from(...) in these places?
@gabrielschulhof gabrielschulhof mentioned this issue Aug 28, 2018
Closed
4 tasks
gabrielschulhof pushed a commit to gabrielschulhof/bleno that referenced this issue Aug 29, 2018
Remove Buffer constructor usage (noble#409)
4e007a6
@gabrielschulhof gabrielschulhof mentioned this issue Aug 29, 2018
Open
@rzr
Copy link

rzr commented Apr 15, 2019 •
edited
Loading

Any feedback from upstream ?

If it helps I am considering to pick this change in forked project:
https://github.com/abandonware/bleno/

Relate-to: #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rzr @gabrielschulhof