Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL preview #301

Open
nitely opened this issue Jan 2, 2021 · 3 comments
Open

URL preview #301

nitely opened this issue Jan 2, 2021 · 3 comments
Labels
feature

Comments

@nitely
Copy link
Owner

nitely commented Jan 2, 2021 •
edited
Loading

Implement links preview for links placed in their own line. Use open-graph (og). Generating the content server side would require a task and re-parsing the raw comment. Check it was not modified in the meantime, and atomically update it using the timestamp. We could use JS instead but making requests to random sites without the user consent doesn't sound good.

On a second thought we already do random requests to get images, so fetching the og content would not be worse than that. I'm more incline in solving this with JS.
@nitely nitely added the feature label Jan 2, 2021
@hammadarshad1
Copy link

Is this feature added or not?

@nitely
Copy link
Owner Author

nitely commented Jul 24, 2021

no

@hammadarshad1
Copy link

Can you please explain this to me? so, I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nitely @hammadarshad1