Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Creating rails template without addons doesn't import spec helper files #330

Open
bterone opened this issue May 27, 2022 · 0 comments
Assignees

Comments

@bterone
Copy link
Contributor

bterone commented May 27, 2022

Issue

When creating a new project and selecting no to all addons, the project doesn't import some helpers e.g. rails_helper.rb, spec_helper.rb and disable_animation.rb which causes issues when running tests

Expected

Correctly import the spec helpers regardless of what addons are picked

Steps to reproduce

  1. Create a project using the template with no addons
  2. Host project on Github and run Github workflows
  3. Observe failure in the docker-asset-precompile step

failure

@bterone bterone added this to the 5.1.0 milestone May 27, 2022
@malparty malparty modified the milestones: 5.1.0, 5.2.0 Jul 15, 2022
@malparty malparty modified the milestones: 5.2.0, 5.3.0 Sep 9, 2022
@malparty malparty removed this from the 5.3.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants