Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab local API #29

Open
Dimitri281 opened this issue May 19, 2021 · 3 comments
Open

Gitlab local API #29

Dimitri281 opened this issue May 19, 2021 · 3 comments

Comments

@Dimitri281
Copy link

Dimitri281 commented May 19, 2021

Versions
Wordpress: 5.7.2
Documents for Git: 1.1.1

Hello i have one specific case to show you,

we are in closed environement , we working only with local resource,
i see in class-base-loader.php the line for initiate the github api :

private static $GITHUB_MARKDOWN_API = 'https://api.github.com/markdown';

do u think it's verry hard to change for use a gitlab api V4 locally (https://my_own_gitlab.lan/api/v4/markdown) ?

TIA.

Dimitri

@nilsnolde
Copy link
Owner

Ah nice, I missed that Gitlab introduced its own markdown API recently! So thanks @Dimitri281!

It's not very hard but quite a bit of shuffling code around. In that case I'd like to make the whole markdown endpoint user-configurable in the settings.json. What do you think about that?

Maybe there are even other renderers I don't know about and honestly, Github's API is a little painful with anchor references (always need to prefix with user-content- 🙄 ).

That being said, I see 2 options:

  1. You give it a shot yourself and I can review the PR
  2. You contact us on enquiry[at]gis-ops.com and we can send you an offer to implement the functionality

@nilsnolde
Copy link
Owner

ah well, maybe gitlab's markdown api is not that recent, was merged 3 years ago 😅

@Dimitri281
Copy link
Author

😅 It is true that our use case is slightly specific but in any case you have really done a great job, and thank you for your quick response, I think to tweak a little trick on a corner of the table to meet our need but if I will take care of it in the next few days. It is with pleasure that I will send it to you, if I do not have time to look into it I will ask my superiors if we can imagine making a commercial request on this subject. .
i wish u a good day and looking forward to conversing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants