Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic language: after installing the plugin the entire site shifts right #16

Open
FarisZR opened this issue Jun 28, 2020 · 4 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@FarisZR
Copy link

FarisZR commented Jun 28, 2020

Versions
Wordpress: 5.4.2
Documents for Git: 1.0.2

Describe the bug
i have just installed the plugin and was looking up to using it,
but when i enable it the entire website shifts right.
the control panel also shifted, and i cant disable the plugin without resizing to mobile size
image

Paste the shortcode and the censored contents of config.json

shortcode

{
  "limit": 5,
  "classes": "",
  "Github": {
    "user": "",
    "token": ""
  },
  "Bitbucket": {
    "user": "",
    "token": ""
  },
  "Gitlab": {
    "user": "",
    "token": ""
  }
}

To Reproduce
Steps to reproduce the behavior:
1.install the plugin

Expected behavior

the plugin should not shift the entire site

Screenshots

image

Additional context

the websites main language is arabic and its RTL based

@nilsnolde
Copy link
Owner

Hm, I have NO clue what could be happening here. When the plugin installs it doesn't do much, it only registers some shortcodes and filters. There's no extra UI or anything, so I don't think it would have to worry about text directionality.

I'll try it out soon myself. But to be honest, I'm not very hopeful I can be of great help here. You don't see this behavior for any other plugin?

@FarisZR
Copy link
Author

FarisZR commented Jun 29, 2020

the issue clearly connected to the arabic language
i think the plugin is trying to switch the website to LTR

@FarisZR
Copy link
Author

FarisZR commented Jul 3, 2020

any updates?

@nilsnolde nilsnolde added bug Something isn't working help wanted Extra attention is needed labels Aug 9, 2020
@nilsnolde nilsnolde changed the title after installing the plugin the entire site shifts right Arabic language: after installing the plugin the entire site shifts right Aug 9, 2020
@nilsnolde
Copy link
Owner

Sorry for the late answer @fareszr . I fear I can't help too much here. I tried with Arabic and could reproduce the issue you're reporting. However, still no idea what could be the cause. I tried a few other plugins but couldn't really see the same behavior there. I tried the RTL tester plugin and there is works great, no matter what the language settings. So, maybe that could be a worst-case workaround for you: activate the RTL tester plugin, permanently set it to RTL and Arabic as language. Not sure if that works.

Like I said, our plugin actually doesn't do much and close to nothing related to UI. It enqueues a few style sheets, but they shouldn't mess up WP styles, the CSS rules are targeted at markdown and jupyter notebooks.

Hope you can make it work somehow and if you do, please either PR or leave a note how you did it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants