Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type passed to getRouterCollection? #5

Open
srottem opened this issue Sep 25, 2016 · 5 comments
Open

Wrong type passed to getRouterCollection? #5

srottem opened this issue Sep 25, 2016 · 5 comments

Comments

@srottem
Copy link

srottem commented Sep 25, 2016

I'm getting the following error when trying to use this component:

Type error: Argument 1 passed to NilPortugues\Laravel5\JsonApiDingo\DingoProvider::getRouterCollection() must be an instance of Illuminate\Routing\UrlGenerator, instance of Dingo\Api\Routing\Router given

It looks like what should really be passed to this function is an instance of Dingo\Api\Routing\UrlGenerator and the function should accept Illuminate\Contracts\Routing\UrlGenerator.

Have I misconfigured something or is this a bug?

@nilportugues
Copy link
Owner

Mind sharing laravel and dingo versions? Might be related in some unnanounced break from the dependencies.

@srottem
Copy link
Author

srottem commented Sep 26, 2016

"minimum-stability": "dev",
"require": {
"php": ">=5.5.9",
"laravel/framework": "5.2.",
"tymon/jwt-auth": "0.5.
",
"dingo/api": "1.0.x@dev",
...

dingo/api dev-master 242411e
laravel/framework 5.2.x-dev 557b9f6

@roberttolton
Copy link

I'm also seeing this bug:

Type error: Argument 1 passed to NilPortugues\\Laravel5\\JsonApiDingo\\DingoProvider::getRouterCollection() must be an instance of Illuminate\\Routing\\UrlGenerator, instance of Dingo\\Api\\Routing\\Router given, called in \/vagrant\/vendor\/nilportugues\/laravel5-json-api-dingo\/src\/NilPortugues\/Laravel5\/JsonApiDingo\/DingoProvider.php on line 30
"require": {
    "php": ">=5.6.4",
    "laravel/framework": "5.3.*",
    "dingo/api": "1.0.x@dev",
    "tymon/jwt-auth": "0.5.*",
    "nilportugues/laravel5-json-api-dingo": "^1.0"
},

@adamherbert
Copy link

Did you ever find a solution to this error?

@falkon
Copy link

falkon commented May 19, 2017

The same error!

"require": {
        "php": ">=5.6.4",
        "laravel/framework": "5.4.*",
        "tymon/jwt-auth": "^0.5.9",
        "dingo/api": "1.0.x@dev",
        "barryvdh/laravel-cors": "^0.8.2",
        "nilportugues/laravel5-json-api-dingo": "^1.0"
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants