Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] dependency isn't being installed #98

Open
jjenzz opened this issue May 24, 2016 · 9 comments
Open

[email protected] dependency isn't being installed #98

jjenzz opened this issue May 24, 2016 · 9 comments

Comments

@jjenzz
Copy link

jjenzz commented May 24, 2016

I'm using npm v3.8.6 and node v6.1.0 but the marked dependency is not being installed into gulp-ngdocs/node_modules so I get a ReferenceError when trying to serve the docs. All other dependencies install fine.

Some searching brought me to #79 but I have gulp-ngdocs v0.2.13 which contains this patch and still doesn't seem to be working. Any ideas?

@EricWafford
Copy link

I'm also having a similar issue, but only started looking at it today. Will report back any findings.

@EricWafford
Copy link

Same situation, Angular, Angular Animate, and Marked all don't get installed for some reason. I navigated directly to the directory and ran npm install and got everything to work after that.

NPM 3.8.9
Node 6.2.0
gulp-npdoc 0.2.13

@paulhhowells
Copy link

paulhhowells commented Jun 9, 2016

I am also experiencing this (but was not a month or two back).

The index.html was loading angular and angular-animate just fine, but was failing because it could not find marked.js. As @EricWafford found, running npm install inside gulp-ngdocs installed a heap of dependencies with the result that after generating another set of docs they worked just fine.

NPM 3.9.5
Node 4.40
gulp-ngdocs 0.2.13

As an aside, when I had gulp-ngdocs running fine a month or so back I was passing in urls for all the angular scripts .pipe(plug.ngdocs.process({ scripts : [] })). While debugging the current situation I noticed that these were now superfluous, and being loaded in addition to the angular files gulp-ngdocs was supplying. i.e. overwriting was not happening.

@paulhhowells
Copy link

paulhhowells commented Jun 9, 2016

I’ve just installed gulp-ngdocs in a fresh directory and the dependencies seem to install just fine (including marked.js), which has me wondering if the issue could be due to a dependency conflict.

I also couldn’t help noticing npm’s advice:
npm WARN prefer global [email protected] should be installed with -g

Might not be a bad idea to update lodash to ^4.0.0

@EricWafford
Copy link

I tried loading it into an existing large angular project, so not sure if that was my issue or not. I will try loading in something else and see if I can't get it to install correctly without having to walk down to the module.

I wonder why they would prefer it to be globally installed. I've always tried to keep my globals down to a minimum.

@EricWafford
Copy link

I also noticed that it was adding scripts in addition to and not replacing those scripts while I was attempting to debug @paulhhowells. I get why they have the option, but I think the documentation on it is misleading as it relates to the core files.

@rickdgeerling
Copy link

Just ran into this but it seems the issue is already fixed by c96abaf

You can fix this by (as suggested by ErirWafford) running npm install inside gulp-ngdocs directory or by modifying your package.json to use the latest version from git: "gulp-ngdocs": "nikhilmodak/gulp-ngdocs"

@teone
Copy link

teone commented Jul 21, 2016

Another options is to add "postinstall": "cd node_modules/gulp-ngdocs/; npm install" to your package.json but this (as manually installing modules) is a workaround, I'd like to see the npm release fixed (specially if it is already fixed in master)

@huerlisi
Copy link

A new release including the npm 3 fixes has been published a couple days ago. Could you give this some testing pls:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants