From 1c53b4e54133354e41be27d6f7346b3eba2977b9 Mon Sep 17 00:00:00 2001 From: MattPM Date: Sat, 15 Jun 2024 20:24:04 -0400 Subject: [PATCH] update CRAN comments. --- NEWS.md | 5 ++++- cran-comments.md | 49 ++++++++++++++---------------------------------- 2 files changed, 18 insertions(+), 36 deletions(-) diff --git a/NEWS.md b/NEWS.md index 7e1eddd..4973135 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,9 @@ # dsb 1.0.4 -This is a patch with a fix in one of the internal conditional checks https://github.com/niaid/dsb/pull/47. No other function updates. Fixed a line in documentation. +This is a patch. +Includes this conditional check: https://github.com/niaid/dsb/pull/47. +No other function updates. +Updated documentation. # dsb 1.0.3 diff --git a/cran-comments.md b/cran-comments.md index 29486bb..6a7b95a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,40 +1,19 @@ -### Submission March 17 2023 +### Submission 15 June 2024 -R CMD check results ───── dsb 1.0.3 ──── -Duration: 1m 15.3s -0 errors ✓ | 0 warnings ✓ | 0 notes ✓ +R CMD check results ─ dsb 1.0.4 ──── +Duration: 1m 16.9s -devtools::check_win_release() -* DONE -Status: 1 Note +0 errors ✔ | 0 warnings ✔ | 0 notes ✔ -Package was archived on CRAN -X-CRAN-Comment: Archived on 2023-03-16 as issues were not corrected in time. +devtools::check_win_release() +Status: OK +using log directory 'd:/RCompile/CRANguest/R-release/dsb.Rcheck' +* using R version 4.4.0 (2024-04-24 ucrt) +* using platform: x86_64-w64-mingw32 +* R was compiled by + gcc.exe (GCC) 13.2.0 + GNU Fortran (GCC) 13.2.0 +* running under: Windows Server 2022 x64 (build 20348) -Found the following (possibly) invalid URLs: -**These links will be valid as soon as the package is back on CRAN. These links should remain unchanged. These are the correctly formatted links as required by CRAN on previous releases of this package.** -https://CRAN.R-project.org/package=dsb/vignettes/additional_topics.html -https://CRAN.R-project.org/package=dsb/vignettes/end_to_end_workflow.html -https://CRAN.R-project.org/package=dsb/vignettes/no_empty_drops.html -https://CRAN.R-project.org/package=dsb/vignettes/understanding_dsb.html - - - -"Possibly misspelled words in DESCRIPTION:" -**These are not misspelled and are unchanged from the previous CRAN releases of this package.** - ADT (21:259) - Denoise (3:20) - Tsang (21:1161) - UMI (21:193) - denoising (21:79) - dsb (21:1041, 21:1093) - isotype (21:698) - - -Previous submission: -- Fix issue related to a package startup message only on linux distributions; this was not previously a problem. I was contacted by the CRAN team. The startup message is not at all required for functionality; it is now deleted. - -original message -*It looks like this package (or a package it requires) has a startup -message which cannot be suppressed: see ?packageStartupMessage.* +This is a patch with no new dependencies.