Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Toggle Password Visibility Not Working. #1156

Closed
2 of 3 tasks
rasel9t6 opened this issue Oct 28, 2023 · 10 comments
Closed
2 of 3 tasks

Bug: Toggle Password Visibility Not Working. #1156

rasel9t6 opened this issue Oct 28, 2023 · 10 comments
Assignees
Labels
🐞 bug This is a patch, generally fixing some bugs. invite me to the organisation Sends an invitation to your community organisation. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@rasel9t6
Copy link

rasel9t6 commented Oct 28, 2023

Description

Toggle password visibility not working on the Sign up and Log in / Sign in page. As a result, users will not be able to understand or review whether their provided password and Confirm password is incorrect or correct / match or mismatch.

Proposed Solution

This might be a solution from W3 Schools Documentation. Bellow the Link
W3 School Doc

Screenshots

Screenshot 2023-10-28 231616
Screenshot 2023-10-28 233258

Browser 🥦

Mozilla Firefox

Checklist ✅

@rasel9t6 rasel9t6 added hacktoberfest This issue is a part of hacktoberfest 2023. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Oct 28, 2023
@github-project-automation github-project-automation bot moved this to Todo in Milan Oct 28, 2023
@github-actions
Copy link

Hello @rasel9t6, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@P-Jaswanth
Copy link

P-Jaswanth commented Oct 28, 2023

Hey, I would like to work on this. Could you please assign this to me.

@Aryashakya
Copy link

I have tried it and it is working for me.
image
image

@rasel9t6
Copy link
Author

I have tried it and it is working for me. image image
It's not working for me.

@tamalCodes
Copy link
Member

Hey @rasel9t6 , it is working fine for me (Chrome, Brave). I'm not sure if there's gonna be a problem in Mozilla, can you try clearing out all the cache and try once again ?

@tamalCodes tamalCodes added status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Oct 30, 2023
@MangeshGawas
Copy link

MangeshGawas commented Nov 29, 2023

Hey, @rasel9t6
Its an bug in mozilla firefox browser , I Fixed that bug.[

Milan._.Signup.Mozilla.Firefox.2023-11-29.20-00-40.mp4

](url)

@tamalCodes
Copy link
Member

tamalCodes commented Nov 30, 2023

Hi @MangeshGawas, would be great if you can make a PR 🚀

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@tamalCodes tamalCodes moved this from Todo to In Progress (Issues) in Milan Nov 30, 2023
@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed hacktoberfest This issue is a part of hacktoberfest 2023. status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue. labels Nov 30, 2023
MangeshGawas added a commit to MangeshGawas/Milan that referenced this issue Nov 30, 2023
@MangeshGawas
Copy link

code committed

@tamalCodes
Copy link
Member

Do raise a PR, and remove the package-lock.json file from the changes too.
Make sure you read our docs on how to make a proper PR !

@github-project-automation github-project-automation bot moved this from In Progress (Issues) to Merged/Discarded in Milan Jan 11, 2024
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Mar 12, 2024
Copy link

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. invite me to the organisation Sends an invitation to your community organisation. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Status: Merged/Discarded
Development

No branches or pull requests

5 participants