Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_html seems to be broken #1107

Closed
wangenau opened this issue Apr 11, 2024 · 1 comment · Fixed by #1112
Closed

write_html seems to be broken #1107

wangenau opened this issue Apr 11, 2024 · 1 comment · Fixed by #1112
Assignees
Labels

Comments

@wangenau
Copy link

Hi,

I am back with another bug report. It seems to me, that the write_html function is broken in the 3.1.* versions of nglview.
This can simply be tested, e.g., with

import nglview
view = nglview.show_structure_file("test.pdb")
nglview.write_html("index.html", view)

While in version 3.0.8 a working HTML file is produced, starting with version 3.1.0 I only get two Click to show javascript error. messages in the produced HTML.

It seems that some models are missing from the new HTML file, but I have attached the files produced with both versions at the bottom. Maybe you can make more sense out of the diff.

Best wishes,
Wanja

html_files.zip

@hainm
Copy link
Collaborator

hainm commented Apr 11, 2024

hi @wangenau

It's a known issue with NGL, which is used by nglview: nglviewer/ngl#1014

May be I can make a hack by replacing the latest version to 3.0.8 when writing html file, for now.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants