Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve descriptions in mapping file #33

Open
Tracked by #1
kMutagene opened this issue Oct 24, 2024 · 3 comments
Open
Tracked by #1

improve descriptions in mapping file #33

kMutagene opened this issue Oct 24, 2024 · 3 comments
Assignees

Comments

@kMutagene
Copy link
Member

No description provided.

@kMutagene kMutagene transferred this issue from nfdi4plants/arc-ro-crate-profile Oct 24, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 24, 2024
@kMutagene kMutagene moved this to Ready in ARCStack Oct 25, 2024
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Oct 25, 2024
@floWetzels
Copy link
Collaborator

@kMutagene Can you specify what kind of improvements you wish to see? @HLWeil and I are unsure whether we should include descriptions for every property (this would be redundant with the profile description) or only specific properties where it is not easy to see.

@kMutagene
Copy link
Member Author

kMutagene commented Dec 18, 2024

Been a while since i discussed this with @HLWeil but i think in the mapping file we wanted to see more reasoning/explanation behind the non-trivial mappings, i think a prime candidate here is processSequence -> about. I'd agree that there does not need to be more info about something like description -> description.

@floWetzels
Copy link
Collaborator

I agree that for such mappings a precise description of reasoning can be helpful. But where do we draw the line? For example, is technologyType -> measurementMethod a trivial mapping or not? How about studies -> hasPart and dataFiles -> hasPart?
Also, all properties are described in the profile itself, e.g. processSequence/about is described by "The experimental processes performed in this study". I agree that this does not include reasoning on why this mapping was chosen, but again, there is some fuzziness here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants