Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-reuse check algorithm re-checks already known keys for each new sector key found #5

Open
aczid opened this issue Nov 24, 2020 · 1 comment

Comments

@aczid
Copy link

aczid commented Nov 24, 2020

Excerpt of the problem:

Sector 38 - Unknown Key A               Unknown Key B
Sector 39 - Found   Key A: 000000000000 Found   Key B: 000000000000

...

     266 | 22A |    1907 | Brute force phase completed. Key found: 72de9a8d5256    |               0 |    0s          
Checking for key reuse...
[Key: 000000000000] -> [xxxxxxxxxxxxxxxxxxxxxx/................x]
[Key: 72de9a8d5256] -> [xxxxxxxxxxxxxxxxxxxxxx/..........

This is not the smart way to do it, and also it appears the code hangs there. :-(

I would expect the key-reuse check to only test the newly found key, and keep its earlier sector key results.

@vk496
Copy link
Collaborator

vk496 commented Nov 24, 2020

The main algorithm should be redone. Is not the first time issues related to a bad workflow...

Probably this is related: vk496/mfoc#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants