Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOUBLET_REMOVAL publishDir error #139

Closed
alexhermida opened this issue Jan 17, 2025 · 4 comments · Fixed by #140
Closed

DOUBLET_REMOVAL publishDir error #139

alexhermida opened this issue Jan 17, 2025 · 4 comments · Fixed by #140
Labels
bug Something isn't working

Comments

@alexhermida
Copy link

Description of the bug

Hello, thank you for the work in this project.

We encounter the following issue running this pipeline at the DOUBLET_DETECTION:DOUBLET_REMOVAL process.

No signature of method: groovy.util.ConfigObject.endsWith() is applicable for argument types: (String) values: [.json]

Looking to the code it looks like a bug was introduced in PR #133 in the modules.config file

saveAs: { filename -> filename.equals('versions.yml') && nullfilfilename.endsWith('.json') ? filename : null }

I've be happy to open a PR for fixing if you point us the preferred logic for that statement.

Best

Command used and terminal output

Relevant files

No response

System information

No response

@alexhermida alexhermida added the bug Something isn't working label Jan 17, 2025
@nictru
Copy link
Collaborator

nictru commented Jan 17, 2025

Hey, thanks for pointing this out. Will probably be an easy fix, I can look into it later today

@alexhermida
Copy link
Author

Thank you for the prompt reply @nictru that would be great.

@nictru nictru linked a pull request Jan 17, 2025 that will close this issue
@nictru
Copy link
Collaborator

nictru commented Jan 17, 2025

Ok apparently I just slipped on the keyboard or something

The code in this location should make sure that the versions.yml file and the .yml file for MultiQC are not added to the publishDir, as they are above represented in the MultiQC report.

@nictru
Copy link
Collaborator

nictru commented Jan 17, 2025

If the problem persists, feel free to re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants