VCF convert + VEP #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvnieuwk
requested changes
May 7, 2024
nvnieuwk
requested changes
May 13, 2024
nvnieuwk
reviewed
May 13, 2024
There was a problem hiding this comment.
Looking very good! Can you also add support for bgzipped VCF files as input to the annotation? (This should be easy as it just means you should tweak the pattern in the schema and add an additional schema value for the VCF index (.vcf.gz.tbi))
As far as I know, the pipeline actually already generates bgzipped VCFs using the bedgovcf module, right?
nvnieuwk
approved these changes
May 14, 2024
|
Well done @BertGalle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nf-test test main.nf.test -profile test,docker).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).