You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had two main reasons for including the vendored scripts in the template.
I didn't want to require users to set up the subrepo
I wanted to make sure that the use of the scripts within the template matched the version of the vendored scripts included.
If we keep the vendored scripts in the template, we just need to document the workaround for the error.
Technically the workaround is already documented in the vendored README, so we just need to point those docs for troubleshooting.
On the other hand, if we don't include the vendored scripts in the template, then we would need additional steps for setting up the ingest workflow:
User needs to install git-subrepo
User needs to set up the subrepo from a specific commit hash with:
Reopening this to remove the vendored scripts from ingest once we move all the potential augur curate scripts to official Augur commands. This will reduce burden on external users to install and manage the subrepo.
This didn't occur to me until I was reviewing the nextstrain/dengue#13 and saw the vendored scripts were pulled in separately. This is nice because then the
vendored/.gitrepo
file is set up correctly from the start. The seasonal-cov repo was copied from this template, so the vendored/.gitrepo file points to a parent commit in this repo.This means when you try to pull in the latest vendored scripts from within seasonal-cov, you run into an error:
I had two main reasons for including the vendored scripts in the template.
If we keep the vendored scripts in the template, we just need to document the workaround for the error.
Technically the workaround is already documented in the vendored README, so we just need to point those docs for troubleshooting.
On the other hand, if we don't include the vendored scripts in the template, then we would need additional steps for setting up the ingest workflow:
If they ever want to update the subrepo to the latest version in the future, they would also need to specify the branch in the pull:
The text was updated successfully, but these errors were encountered: