Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioconda workflow failed with push error due to insufficient permissions #1509

Open
corneliusroemer opened this issue Jul 11, 2024 · 7 comments
Labels
t:bug Type: bug, error, something isn't working

Comments

@corneliusroemer
Copy link
Member

+ git push nextstrain upstream/master:master
To https://github.com/nextstrain/bioconda-recipes
 ! [remote rejected]       upstream/master -> master (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/Bulk.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/nextstrain/bioconda-recipes'
Error: Process completed with exit code 1.

https://github.com/nextstrain/nextclade/actions/runs/9884976601/job/27302228960

@corneliusroemer corneliusroemer added t:bug Type: bug, error, something isn't working good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels Jul 11, 2024
@corneliusroemer
Copy link
Member Author

I've seen this before in a different repo, I think this might be due to some changes on our fork vs the bioconda master.

@corneliusroemer
Copy link
Member Author

Seems to happen stochastically, e.g. last time here.

Maybe we can just retry he action 3 times before failing eventually?

https://github.com/nextstrain/nextclade/actions/runs/9577731744/job/26406514723

@corneliusroemer
Copy link
Member Author

Alternatively the issue could be that the nextstrain fork isn't up to date, we might want to sync it first?

@corneliusroemer
Copy link
Member Author

A manual sync of our nextstrain fork fixed it. We should probably do this every time automatically before pushing at the start of the workflow. Or we give the PAT workflow permissions.

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Jul 11, 2024

Context: https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1683672353211379

This thing fails every time bioconda touches their GHA workflows. Me and Tom tried different ways to update the fork, but nothing seems to be working.

Current thing:

## Add Nextstrain fork (https://github.com/nextstrain/bioconda-recipes) as a remote
git remote add nextstrain "https://github.com/nextstrain/bioconda-recipes" >/dev/null
# Update master branch of the fork
git push nextstrain upstream/master:master

I just do this manually every time it fails. But forgot to check this time.

The problem is nonsensical. Would be nice to find a solution.

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Jul 11, 2024

I've been thinking lately (in general) what is the value proposition of GitHub forks? That GitHub can fail things randomly and gather some intel on who is networking with whom? I mean, it could be just a standalone repo with periodic pushes from origin repo.

@ivan-aksamentov ivan-aksamentov removed good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels Jul 11, 2024
@tsibley
Copy link
Member

tsibley commented Jul 11, 2024

@ivan-aksamentov There's not a compelling reason for the repo in its current state to be a GitHub fork, other than making it maybe slightly clearer in the GitHub UI what it's related to. I believe you can submit PRs to repos from arbitrary other repos, without them being marked as a GitHub fork. So we could disassociate it. But that wouldn't solve the issue of the token not being allowed to introduce new GitHub Actions workflow files, right?

(I followed up in Slack too.)

@corneliusroemer corneliusroemer changed the title Bioconda workflow failed with push error die to insufficient permissions Bioconda workflow failed with push error due to insufficient permissions Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Type: bug, error, something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants