Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextclade Web: consider rethinking dataset badges #1463

Open
ivan-aksamentov opened this issue May 30, 2024 · 1 comment
Open

Nextclade Web: consider rethinking dataset badges #1463

ivan-aksamentov opened this issue May 30, 2024 · 1 comment
Labels
t:feat Type: request of a new feature, functionality, enchancement

Comments

@ivan-aksamentov
Copy link
Member

Reported by @tsibley here

External datasets like this are tagged "community", e.g.

image

and while I get why this is, it feels potentially pretty confusing to users. In particular because a) this is an official nextstrain.org core dataset and b) nextstrain.org has its own meaning for "community dataset". Should we rethink the UI here a little? Mark https://nextstrain.org core datasets as "official"? Or with some other label than "community"? (These are unification/integration pains, which feel hard, but also worth it.)

@ivan-aksamentov ivan-aksamentov added t:feat Type: request of a new feature, functionality, enchancement good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment and removed good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment labels May 30, 2024
@ivan-aksamentov
Copy link
Member Author

ivan-aksamentov commented May 30, 2024

Current logic is something like

badge = dataset_collection == "nextstrain" ? "official" : "community"

We might simply display the name of the collection instead. And if no collection, then some static value e.g. "external" or nothing at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feat Type: request of a new feature, functionality, enchancement
Projects
None yet
Development

No branches or pull requests

1 participant