Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer entropy panel loading but don't load lazily #1899

Open
corneliusroemer opened this issue Nov 13, 2024 · 1 comment
Open

Defer entropy panel loading but don't load lazily #1899

corneliusroemer opened this issue Nov 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

As part of performance improvements the entropy panel no longer loads when it is outside the viewport. It loads lazily, only when the panel comes into view.

To me it feels like a regression that now the entropy panel shows data loading for a split second when I scroll it into view.

Would it be possible to not load it lazily but instead paint it once the main work has been done?

Alternatively, the entropy panel could only be loaded lazily once the tree/view is above a certain size threshold so that the loading is only delayed when it really matters performance wise.

@corneliusroemer corneliusroemer added the enhancement New feature or request label Nov 13, 2024
@jameshadfield
Copy link
Member

As part of performance improvements the entropy panel no longer loads when it is outside the viewport.

To be specific, the panel's still loaded but the data behind the bars isn't recomputed and the bars aren't repainted.

it feels like a regression that now the entropy panel shows data loading for a split second when I scroll it into view

Yeah, this is a trade off (see #1879 for context). The delay you see here is time saved on essentially every single interaction in Auspice. (If you interact in a way which doesn't invalidate the entropy data then the entropy panel doesn't show "data loading".) I get that it's annoying to see "data loading" but I think it's better to have improved performance elsewhere.

Would it be possible to not load it lazily but instead paint it once the main work has been done?

In short, yes. There's a few options to explore here (web workers, requestIdleCallback). Hopefully we can continue improving performance (there hasn't been much work here for a long time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants