Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag-and-drop metadata not available as tip labels #1844

Closed
joverlee521 opened this issue Sep 3, 2024 · 1 comment · Fixed by #1845
Closed

drag-and-drop metadata not available as tip labels #1844

joverlee521 opened this issue Sep 3, 2024 · 1 comment · Fixed by #1845
Assignees
Labels
bug Something isn't working

Comments

@joverlee521
Copy link
Contributor

Reported by user on Slack, most likely related to #1668

  1. Go to zika build
  2. Drag and drop nextstrain_zika_metadata.xlsx
  3. See colors added but not tip labels

Screenshot 2024-09-03 at 11 32 37 AM
Screenshot 2024-09-03 at 11 32 45 AM

@joverlee521
Copy link
Contributor Author

The new metadata is added in place, so there's no Redux state update to trigger the new tip labels to be added

case types.ADD_EXTRA_METADATA:
// add data into `nodes` in-place, so no redux update will be triggered if you only listen to `nodes`
addNodeAttrs(state.nodes, action.newNodeAttrs);

joverlee521 added a commit that referenced this issue Sep 3, 2024
Ensures that new metadata fields added to the tree are included as
new tip labels.

Fixes #1844
@joverlee521 joverlee521 self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant