Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird URL for accounts -> recently active #46776

Open
4 tasks done
kesselb opened this issue Jul 26, 2024 · 3 comments · May be fixed by #47652
Open
4 tasks done

Weird URL for accounts -> recently active #46776

kesselb opened this issue Jul 26, 2024 · 3 comments · May be fixed by #47652
Assignees
Labels

Comments

@kesselb
Copy link
Contributor

kesselb commented Jul 26, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

The URL for the "Recently active" list in the accounts manager is /settings/users/__nc_internal_recent.

It works and it's no problem form a technical point.

Only a bit weird, given that we use cleaner urls for admins and disabled accounts.

Admins: /settings/users/admin
Disabled accounts: /settings/users/disabled

Steps to reproduce

  1. Login as admin
  2. Go to accounts management
  3. Click "Recently active"
  4. Notice url

Expected behavior

A clean url ;)

cc @sorbaugh @Pytal

@kesselb kesselb added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback labels Jul 26, 2024
@kesselb kesselb modified the milestone: Nextcloud 30 Jul 26, 2024
@Pytal
Copy link
Member

Pytal commented Jul 26, 2024

Yes this is intentional, initial idea was to use recent but since this would be breaking went with this id suggested by @susnux

@Pytal Pytal removed the bug label Jul 26, 2024
@Pytal Pytal closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Jul 28, 2024

I see, to avoid conflicts with existing groups.

The id for the disabled accounts section should be changed.

If you add a group and call it "disabled", the section but also the group disappears 🙈

Screencast.from.2024-07-28.19-57-12.webm

I'm reopening the issue for now, please let me know if you want me to log a fresh issue.

@kesselb kesselb reopened this Jul 28, 2024
@susnux
Copy link
Contributor

susnux commented Jul 29, 2024

I think this can be solved by do not use fake groups but provide the groups as special lists.
And the URLs could also just be adjusted to look nice by changing them to e.g.
/settings/users/recent -> recent or disabled etc
/settings/users/group/realGroupId -> for real groups

(or similar)

@Pytal Pytal self-assigned this Jul 30, 2024
@Pytal Pytal added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 30, 2024
@susnux susnux added the bug label Aug 15, 2024
@Pytal Pytal linked a pull request Aug 30, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants