Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inline comments in types #10

Open
provokateurin opened this issue Aug 18, 2023 · 2 comments
Open

Support inline comments in types #10

provokateurin opened this issue Aug 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@provokateurin
Copy link
Member

vimeo/psalm#8168
@provokateurin provokateurin added the enhancement New feature or request label Aug 18, 2023
@provokateurin provokateurin changed the title Suppoet inline comments in types Support inline comments in types Aug 18, 2023
@provokateurin provokateurin mentioned this issue Jan 24, 2024
Closed
@provokateurin
Copy link
Member Author

Not possible at the moment because we use the phpstan doc parser which doesn't support the inline comments like psalm (see the linked issue above). Sadly psalm doesn't expose the parsing libraries separately so we can't use that either (vimeo/psalm#2094).

@provokateurin
Copy link
Member Author

The relevant phpdoc-parser issue is phpstan/phpdoc-parser#184. This feature can not be implemented without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@provokateurin