diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 0000000000..ff211fb847
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,12 @@
+
+* Resolves: #
+
+## Summary
+
+
+
+## Checklist
+
+- Code is [properly formatted](https://nextcloud.github.io/news/developer/#coding-style-guidelines)
+- [Sign-off message](https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md) is added to all commits
+- Changelog entry added for all important changes.
diff --git a/.github/workflows/api-integration-tests.yml b/.github/workflows/api-integration-tests.yml
index 484bf38b39..f7619ff18f 100644
--- a/.github/workflows/api-integration-tests.yml
+++ b/.github/workflows/api-integration-tests.yml
@@ -28,23 +28,19 @@ jobs:
- 5432:5432 # Maps tcp port 5432 on service container to the host
strategy:
matrix:
- php-versions: ['7.4', '8.0']
- nextcloud: ['stable23', 'stable24', 'stable25']
+ php-versions: ['8.0', '8.1']
+ nextcloud: ['stable27']
database: ['sqlite', 'pgsql', 'mysql']
experimental: [false]
include:
- - php-versions: '8.0'
+ - php-versions: 8.1
nextcloud: pre-release
database: sqlite
experimental: true
- - php-versions: '8.2'
+ - php-versions: 8.2
nextcloud: pre-release
database: sqlite
experimental: true
- - php-versions: 8.1
- nextcloud: stable25
- database: sqlite
- experimental: false
steps:
- name: Checkout
uses: actions/checkout@v3
@@ -126,9 +122,6 @@ jobs:
kill %1
kill %2
- - name: Setup problem matchers for PHP
- run: echo "::add-matcher::${{ runner.tool_cache }}/php.json"
-
- name: Functional tests maintenance
working-directory: ../server
run: |
diff --git a/.github/workflows/api-php-static-code-check.yml b/.github/workflows/api-php-static-code-check.yml
index 57776f4002..37035c2447 100644
--- a/.github/workflows/api-php-static-code-check.yml
+++ b/.github/workflows/api-php-static-code-check.yml
@@ -7,11 +7,11 @@ jobs:
continue-on-error: true
strategy:
matrix:
- php-versions: [ '7.4', '8.0', '8.1' ]
- nextcloud: [ 'stable25' ]
+ php-versions: ['8.0', '8.1', '8.2' ]
+ nextcloud: [ 'stable27' ]
database: [ 'sqlite' ]
include:
- - php-versions: '8.2'
+ - php-versions: 8.2
nextcloud: pre-release
database: sqlite
experimental: true
diff --git a/.github/workflows/api-php-tests.yml b/.github/workflows/api-php-tests.yml
index 0a26353165..1b309daf85 100644
--- a/.github/workflows/api-php-tests.yml
+++ b/.github/workflows/api-php-tests.yml
@@ -10,16 +10,10 @@ jobs:
strategy:
matrix:
php-versions: ['8.1']
- nextcloud: ['stable25']
+ nextcloud: ['stable27']
database: ['sqlite']
experimental: [false]
codecoverage: [false]
- include:
- - php-versions: 8.0
- nextcloud: stable24
- database: sqlite
- experimental: false
- codecoverage: true
steps:
- name: Checkout
uses: actions/checkout@v3
@@ -50,9 +44,6 @@ jobs:
app: 'news'
check-code: false
- - name: Setup problem matchers for PHPUnit
- run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
-
- name: Prep PHP tests
working-directory: ../server/apps/news
run: make php-test-dependencies
diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml
index 06b1f4c3dd..636235de00 100644
--- a/.github/workflows/build-release.yml
+++ b/.github/workflows/build-release.yml
@@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
php-versions: ['8.1']
- nextcloud: ['stable25']
+ nextcloud: ['stable27']
database: ['sqlite']
steps:
- name: Checkout
@@ -29,7 +29,7 @@ jobs:
coverage: none
- name: Set up server non MySQL
- uses: SMillerDev/nextcloud-actions/setup-nextcloud@fae87e29aa7cdf1ea0b8033c67f60e75b10be2cd
+ uses: SMillerDev/nextcloud-actions/setup-nextcloud@main
with:
cron: false
version: ${{ matrix.nextcloud }}
@@ -39,7 +39,7 @@ jobs:
run: make
- name: Configure server with app
- uses: SMillerDev/nextcloud-actions/setup-nextcloud-app@fae87e29aa7cdf1ea0b8033c67f60e75b10be2cd
+ uses: SMillerDev/nextcloud-actions/setup-nextcloud-app@main
with:
app: ${{ env.APP_NAME }}
check-code: false
@@ -52,7 +52,7 @@ jobs:
app_public_crt: ${{ secrets.APP_PUBLIC_CRT }}
- name: Upload app tarball to release
- uses: svenstaro/upload-release-action@133984371c30d34e38222a64855679a414cb7575
+ uses: svenstaro/upload-release-action@2b9d2847a97b04d02ad5c3df2d3a27baa97ce689
id: attach_to_release
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/frontend-nodejs-tests.yml b/.github/workflows/frontend-nodejs-tests.yml
index d78409ae40..e077e7d1b9 100644
--- a/.github/workflows/frontend-nodejs-tests.yml
+++ b/.github/workflows/frontend-nodejs-tests.yml
@@ -4,13 +4,13 @@ on:
jobs:
php:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
continue-on-error: ${{ matrix.experimental }}
name: "Frontend: Nextcloud ${{ matrix.nextcloud }} - PHP ${{ matrix.php-versions }} - DB ${{ matrix.database }}"
strategy:
matrix:
php-versions: ['8.1']
- nextcloud: ['stable24']
+ nextcloud: ['stable27']
database: ['sqlite']
experimental: [false]
steps:
diff --git a/.github/workflows/lint-eslint.yml b/.github/workflows/lint-eslint.yml
index c08763ea94..ec439166b1 100644
--- a/.github/workflows/lint-eslint.yml
+++ b/.github/workflows/lint-eslint.yml
@@ -25,10 +25,10 @@ jobs:
uses: actions/checkout@v3
- name: Read package.json node and npm engines version
- uses: skjnldsv/read-package-engines-version-actions@v1.2
+ uses: skjnldsv/read-package-engines-version-actions@v2.2
id: versions
with:
- fallbackNode: '^12'
+ fallbackNode: '^16'
fallbackNpm: '^6'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
diff --git a/.github/workflows/post-merge-tasks.yml b/.github/workflows/post-merge-tasks.yml
index 6385657d3a..ea446f0ce8 100644
--- a/.github/workflows/post-merge-tasks.yml
+++ b/.github/workflows/post-merge-tasks.yml
@@ -10,7 +10,7 @@ jobs:
name: "Coverage: Nextcloud PHP ${{ matrix.php-versions }}"
strategy:
matrix:
- nextcloud: ['stable25']
+ nextcloud: ['stable27']
steps:
- name: Checkout
uses: actions/checkout@v3
diff --git a/.github/workflows/updater-test.yml b/.github/workflows/updater-test.yml
new file mode 100644
index 0000000000..eb5901a51f
--- /dev/null
+++ b/.github/workflows/updater-test.yml
@@ -0,0 +1,80 @@
+name: Updater Tests
+on:
+ pull_request
+
+env:
+ POSTGRES_PASSWORD: nc_test_db
+ MYSQL_USER: nc_test
+ MYSQL_PASSWORD: nc_test_db
+ MYSQL_DATABASE: nc_test
+ MYSQL_PORT: 3800
+
+jobs:
+ integration:
+ runs-on: ubuntu-latest
+ continue-on-error: ${{ matrix.experimental }}
+ name: "Update Test: Nextcloud ${{ matrix.nextcloud }} - PHP ${{ matrix.php-versions }}"
+ strategy:
+ matrix:
+ php-versions: ['8.1']
+ nextcloud: ['stable27']
+ database: ['sqlite']
+ experimental: [false]
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ with:
+ submodules: recursive
+
+ - name: Setup PHP
+ uses: shivammathur/setup-php@v2
+ with:
+ php-version: ${{ matrix.php-versions }}
+ extensions: pdo_sqlite,pdo_mysql,pdo_pgsql,gd,zip
+ coverage: none
+
+ - name: Setup BATS & httpie
+ run: sudo apt-get install -y httpie && npm install -g bats@1.7.0
+
+ - name: Set up server
+ uses: SMillerDev/nextcloud-actions/setup-nextcloud@main
+ with:
+ version: ${{ matrix.nextcloud }}
+ cron: true
+ database-type: ${{ matrix.database }}
+ database-host: localhost
+ database-port: 5432
+ database-name: postgres
+ database-user: postgres
+ database-password: ${{ env.POSTGRES_PASSWORD }}
+
+ - name: Prime app build
+ run: make
+
+ - name: Configure server with app
+ uses: SMillerDev/nextcloud-actions/setup-nextcloud-app@main
+ with:
+ app: 'news'
+ check-code: false
+ force: ${{ matrix.experimental }}
+
+ - name: Install composer install php-feed-generator
+ working-directory: ../server
+ run: composer install -d apps/news/tests/test_helper/php-feed-generator
+
+ - name: Run Updater tests
+ working-directory: ../server
+ run: |
+ php -S localhost:8080 &> /tmp/webserver.log &
+ cd apps/news/tests/test_helper/feeds && php -S localhost:8090 &> /tmp/feedserver.log &
+
+ sleep 2
+
+ cd ${{ github.workspace }}/../server
+
+ bats apps/news/tests/updater
+
+ # Kill php server
+ kill %1
+ kill %2
+
diff --git a/.gitignore b/.gitignore
index 651ed673e7..649a92217f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,6 +16,9 @@ tests/api/helpers/settings-override.bash
#bats
tests/api/helpers/settings-override.bash
+tests/test_helper/feeds/test.xml
+tests/test_helper/feeds/feed1.xml
+tests/test_helper/feeds/feed2.xml
# python
PKG-INFO
@@ -72,3 +75,6 @@ nbproject
# Mac OS
.DS_Store
*.iml
+
+# VS Code
+.vscode
\ No newline at end of file
diff --git a/.gitmodules b/.gitmodules
index d74af07784..b3b42f3c26 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -4,3 +4,6 @@
[submodule "tests/test_helper/bats-assert"]
path = tests/test_helper/bats-assert
url = https://github.com/bats-core/bats-assert.git
+[submodule "tests/test_helper/php-feed-generator"]
+ path = tests/test_helper/php-feed-generator
+ url = https://github.com/Grotax/php-feed-generator.git
diff --git a/AUTHORS.md b/AUTHORS.md
index 42fe737772..ced11a3355 100644
--- a/AUTHORS.md
+++ b/AUTHORS.md
@@ -50,11 +50,14 @@
* [Daniel Kesselberg](mailto:mail@danielkesselberg.de)
* [ELHADDAD Hamza](mailto:elhaddadhamza49@gmail.com)
* [Jakob Sack](mailto:mail@jakobsack.de)
+* [ManuelSailer](mailto:github.com@manuel-sailer.de)
* [Qingping Hou](mailto:dave2008713@gmail.com)
* [Roman](mailto:reverse@jamm.me)
* [b_b](mailto:bruno@eliaz.fr)
+* [chylex](mailto:contact@chylex.com)
* [heyarne](mailto:arne@schlueter.is)
* [marco.nassabain@etu.unistra.fr](mailto:marco.nassabain@hotmail.com)
+* [Anderson Silva](mailto:UnderEu@users.noreply.github.com)
* [Andreas Fischer](mailto:bantu@owncloud.com)
* [David Guillot](mailto:david@guillot.me)
* [Gioele Falcetti](mailto:thegio.f@gmail.com)
@@ -66,13 +69,13 @@
* [Konrad Graefe](mailto:konradgraefe@aol.com)
* [Loki3000](mailto:github@labcms.ru)
* [Maik Kulbe](mailto:info@linux-web-development.de)
+* [Manuel Sailer](mailto:github.com@manuel-sailer.de)
* [Michael Gapczynski](mailto:mtgap@owncloud.com)
* [Nikita Chernyi](mailto:rakshazi@users.noreply.github.com)
* [Peter Hedlund](mailto:peter@peterandlinda.com)
* [Simon Spannagel](mailto:simonspa@kth.se)
* [bbBowser](mailto:carspi@mail.de)
* [benediktb](mailto:benedikt@blablub.de)
-* [chylex](mailto:contact@chylex.com)
* [coderkun](mailto:olli@coderkun.de)
* [davidak](mailto:git@davidak.de)
* [hooger](mailto:horvathg.1988@gmail.com)
@@ -85,7 +88,6 @@
* [Alexander Grüßung](mailto:alexander@gruessung-online.de)
* [Allan Nordhøy](mailto:epost@anotheragency.no)
* [Alwaysin](mailto:adrien@demma.fr)
-* [Anderson Silva](mailto:UnderEu@users.noreply.github.com)
* [Andrea Boero](mailto:mail@tsumi.it)
* [Andreas Demmelbauer](mailto:git@notice.at)
* [Artem Lavrukhin](mailto:lavryha4590@gmail.com)
@@ -107,6 +109,7 @@
* [Colin W](mailto:cwmke@users.noreply.github.com)
* [Daniel Aleksandersen](mailto:code@daniel.priv.no)
* [Daniel S](mailto:daniel@while-true-do.org)
+* [Daniel Starzmann](mailto:daniel@starze.de)
* [David Baucum](mailto:david@baucum.me)
* [David Engster](mailto:deng@randomsample.de)
* [Dennis Müller](mailto:dennismueller.kontakt@gmail.com)
@@ -129,6 +132,7 @@
* [Hendrik Leppelsack](mailto:hendrik@leppelsack.de)
* [Jasper Knockaert](mailto:jasper@knockaert.nl)
* [Kevin Decherf](mailto:kevin@kdecherf.com)
+* [Kuba Orlik](mailto:kontakt@kuba-orlik.name)
* [Maceček Richard](mailto:46937538+macecekrichard@users.noreply.github.com)
* [Marc Cousin](mailto:marc.cousin@people-doc.com)
* [Martin Ferretti](mailto:ferrettimartin@protonmail.com)
@@ -148,6 +152,7 @@
* [Piotr Dobrowolski](mailto:admin@tastycode.pl)
* [Raspbeguy](mailto:raspbeguy@users.noreply.github.com)
* [René Henrich](mailto:contact@rene-henrich.de)
+* [Robert Wunderer](mailto:robert.wunderer@caprisys.at)
* [Rodrigo Aguilera](mailto:rodrigo.aguilera@amazee.com)
* [Roeland Jago Douma](mailto:roeland@famdouma.nl)
* [Simon](mailto:sschubert89@gmail.com)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2e655e246a..a646485f67 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,13 +3,82 @@ All notable changes to this project will be documented in this file.
The format is mostly based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), older entries don't fully match.
# Unreleased
-## [20.x.x]
+## [23.x.x]
### Changed
- Vue Rewrite
- Add Typescript
- Add Jest for Unit Tests
# Releases
+## [22.0.0] - 2023-07-23
+### Changed
+- Support deflate and gzip compression for HTTP response bodies (#2269)
+- Broke apart old FAQ into different guides. Deprecated old FAQ (#2285)
+
+## [22.0.0-beta2] - 2023-06-18
+### Changed
+- allowEvalScript set to true (#2262)
+
+## [22.0.0-beta1] - 2023-05-18
+### Changed
+- Drop support for Nextcloud 24 (#2223)
+- Add support for Nextcloud 27 (#2223)
+
+## [21.2.0] - 2023-05-06
+### Changed
+- Improve visibility of links in dark theme (#2215)
+
+## [21.2.0-beta4] - 2023-04-16
+### Fixed
+- Fix audio player floating when scrolling in NC25+ (#2142)
+- Fix sorting of folder names in select when adding subscription (#2090)
+
+## [21.2.0-beta3] - 2023-04-16
+### Changed
+- Improve performance of item updates (#1322)
+### Fixed
+- Fix display issue in NC26+ (#2192)
+
+## [21.2.0-beta2] - 2023-04-05
+### Fixed
+- Fix last_modified not updated when all items are marked as read (#2183)
+
+## [21.2.0-beta1] - 2023-03-23
+### Changed
+- Use httpLastModified field for If-Modified-Since header when fetching feed updates (#2119)
+
+## [21.1.0] - 2023-03-20
+No notable changes compared 21.1.0-beta1
+
+## [21.1.0-beta1] - 2023-03-13
+### Changed
+- Remove unused background job OCA\News\Cron\Updater (#2137)
+- (Nextcloud 26+) Add info card to the admin settings, showing last job execution (#2141)
+
+## [21.0.0] - 2023-02-28
+No notable changes compared 21.0.0-beta1
+
+## [21.0.0-beta1] - 2023-02-14
+### Changed
+- Drop support for Nextcloud 23 (#2077 )
+- Make the "open" keyboard shortcut work faster (#2080)
+- Implemented search for articles, results can only link to the feed. (#2075)
+### Fixed
+- Stop errors from the favicon library over empty values (#2096)
+
+## [20.0.1] - 2023-01-19
+### Fixed
+- SyntaxError triggered when full-text is enabled with some items. (#2048, #2053)
+
+## [20.0.0] - 2022-12-14
+### Changed
+- Drop support for PHP 7.3 (#2008)
+- Dependency updates
+
+## [19.0.1] - 2022-12-01
+### Changed
+- Dependency updates
+
## [19.0.0] - 2022-10-25
### Fixed
- Fix nested scrollbars in navigation (#411, #1958)
diff --git a/README.md b/README.md
index fa1ee4db5a..885f9fb7b4 100644
--- a/README.md
+++ b/README.md
@@ -9,6 +9,14 @@ The News app is an RSS/Atom feed aggregator. It offers a [RESTful API](https://n
## Documentation
The documentation can be found [here](https://nextcloud.github.io/news/), the source of the documentation is on [GitHub](https://github.com/nextcloud/news/blob/master/docs)
+### Common Guides
+
+There are some small guides for dealing with common setup and issues.
+
+* [Troubleshooting Guide](docs/troubleshooting.md)
+* [Integration Guide](docs/features/integration.md)
+
+
## Bugs
Please read the [appropriate section in the contributing notices](https://github.com/nextcloud/news/blob/master/CONTRIBUTING.md#issues)
diff --git a/appinfo/info.xml b/appinfo/info.xml
index eeb5af55b9..884a7b041b 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -21,7 +21,7 @@ Create a [feature request](https://github.com/nextcloud/news/discussions/new)
Report a [feed issue](https://github.com/nextcloud/news/discussions/new)
]]>
- 19.0.0
+ 22.0.0
agpl
Benjamin Brahmer
Sean Molenaar
@@ -43,7 +43,7 @@ Report a [feed issue](https://github.com/nextcloud/news/discussions/new)
https://raw.githubusercontent.com/nextcloud/news/master/screenshots/2.png
https://raw.githubusercontent.com/nextcloud/news/master/screenshots/3.png
-
+
pgsql
sqlite
mysql
@@ -55,13 +55,19 @@ Report a [feed issue](https://github.com/nextcloud/news/discussions/new)
json
-
+
OCA\News\Cron\UpdaterJob
+
+
+ OCA\News\Migration\RemoveUnusedJob
+
+
+
OCA\News\Command\ExploreGenerator
OCA\News\Command\ShowFeed
diff --git a/composer.json b/composer.json
index 355c6619b8..fb17d51924 100644
--- a/composer.json
+++ b/composer.json
@@ -40,7 +40,7 @@
"source": "https://github.com/nextcloud/news/"
},
"require": {
- "php": "^7.2 || ~8.0",
+ "php": "~8.0",
"ezyang/htmlpurifier": "^4.16.0",
"pear/net_url2": "^2.2.2",
"riimu/kit-pathjoin": "^1.2.0",
@@ -54,16 +54,16 @@
"ext-curl": "*"
},
"require-dev": {
- "phpunit/phpunit": "9.5.*",
- "squizlabs/php_codesniffer": "^3.7.1",
- "phpstan/phpstan": "^1.9.0",
- "phpstan/phpstan-doctrine": "^1.3.22",
- "phpstan/phpstan-strict-rules": "^1.4.4",
- "phpstan/phpstan-phpunit": "^1.2.2",
- "phpstan/extension-installer": "^1.2.0",
- "phpstan/phpstan-deprecation-rules": "^1.0",
+ "phpunit/phpunit": "9.6.*",
+ "squizlabs/php_codesniffer": "^3.7.2",
+ "phpstan/phpstan": "^1.10.26",
+ "phpstan/phpstan-doctrine": "^1.3.40",
+ "phpstan/phpstan-strict-rules": "^1.5.1",
+ "phpstan/phpstan-phpunit": "^1.3.13",
+ "phpstan/extension-installer": "^1.3.1",
+ "phpstan/phpstan-deprecation-rules": "^1.1",
"guzzlehttp/guzzle": "^7.3.0",
- "doctrine/dbal": "^3.5.1",
+ "doctrine/dbal": "^3.6.5",
"symfony/console": "^4.4.19",
"psr/log": "^1.1.0"
},
diff --git a/docs/admin.md b/docs/admin.md
index 0b2cef164c..b645219e51 100644
--- a/docs/admin.md
+++ b/docs/admin.md
@@ -11,8 +11,11 @@ Alternatively you may use an [external updater](https://nextcloud.github.io/news
Auto purging automatically removes the oldest read items of every feed after every update.
The value you enter here is used as the limit of read items per feed, unless the feed comes with more items in it's feed.
-For example you have the default value of 200 and the feed has 210 items in it's feed.
-In this case the limit will be 210 instead of 200.
+The individual limit per feed is only adjusted when it's bigger. Let's say last feed update came with 210 items,
+then that will be the limit for that feed as long as no bigger update with more items is fetched.
+In this case the limit will be 210 instead of 200, for that feed.
+
+This is needed to prevent items from reappearing in the feed.
## Purge unread items
This changes the behavior of the auto purging to also purge unread items. This is useful if you have users with a lot of unread items.
diff --git a/docs/clients.md b/docs/clients.md
index 411d91f99b..ae046960a4 100644
--- a/docs/clients.md
+++ b/docs/clients.md
@@ -12,6 +12,7 @@ A sync client can be used to read news and synchronize via the API.
| [RSS Guard](https://github.com/martinrotter/rssguard) | Windows, Linux, OS/2, macOS | GPL-3.0 License | [GitHub](https://github.com/martinrotter/rssguard) |
| [Fluent Reader](https://hyliu.me/fluent-reader/) | Windows, Linux, macOS | BSD-3-Clause License | [GitHub](https://github.com/yang991178/fluent-reader) |
| [Communique](https://flathub.org/apps/details/com.github.suzie97.communique) | Linux | LGPL-2.1 License | [GitHub](https://github.com/Suzie97/Communique) |
+| [NewsFlash](https://flathub.org/apps/details/com.gitlab.newsflash) | Linux | GPL-3.0 License | [GitLab](https://gitlab.com/news-flash/news_flash_gtk) |
| [Nextcloud News Reader](https://play.google.com/store/apps/details?id=de.luhmer.owncloudnewsreader) | Android | GPL-3.0 License | [GitHub](https://github.com/nextcloud/news-android-app) |
| [OCReader](https://f-droid.org/repository/browse/?fdid=email.schaal.ocreader) | Android | GPL-3.0 License | [GitHub](https://github.com/schaal/ocreader) |
| [Newsout](https://play.google.com/store/apps/details?id=com.inspiredandroid.newsout) | Android | Apache-2.0 License | [GitHub](https://github.com/SimonSchubert/NewsOut) |
diff --git a/docs/faq.md b/docs/faq.md
deleted file mode 100644
index e9c4d5e953..0000000000
--- a/docs/faq.md
+++ /dev/null
@@ -1,119 +0,0 @@
-# FAQ
-
-## My browser shows a mixed content warning (Connection is Not Secure)
-If you are serving your Nextcloud over HTTPS your browser will very likely warn you with a yellow warnings sign about your connection not being secure.
-
-Chrome will show no green HTTPS lock sign, Firefox will show you the following image
-![Mixed Passive Content](https://ffp4g1ylyit3jdyti1hqcvtb-wpengine.netdna-ssl.com/security/files/2015/10/mixed-passive-click1-600x221.png)
-
-Note that this warning **is not red and won't block the page like the following images** which signal **a serious issue**:
-
-![Untrusted Cert](https://www.inmotionhosting.com/support/images/stories/website/errors/ssl/chrome-self-signed-ssl-warning.png)
-![Mixed Active Content](https://www.howtogeek.com/wp-content/uploads/2014/02/650x367xchrome-mixed-content-https-problem.png.pagespeed.gp+jp+jw+pj+js+rj+rp+rw+ri+cp+md.ic.r_lQiZiq38.png)
-
-### What is the cause of the (yellow) error message
-
-This warning is caused by [mixed passive content](https://developer.mozilla.org/en/docs/Security/MixedContent) and means that your page loads passive resources from non HTTPS resources, such as:
-
-* Images
-* Video/Audio
-
-This allows a possible attacker to perform a MITM (man-in-the-middle) attack by serving you different images or audio/video.
-
-### Why doesn't the News app fix it
-
-The News app fully prevents mixed **active** content by only allowing HTTPS iframes from known locations; other possible mixed active content elements such as