Autodiscovery doesn't work #415

haeckle · 2019-03-11T14:05:44Z

haeckle
Mar 11, 2019

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

I have read the CONTRIBUTING.md and followed the provided tips

Explain the Problem

What problem did you encounter?
Can't subscribe to GitHub release page via autodiscovery

Steps to Reproduce

Explain what you did to encounter the issue

Try to subscribe to https://github.com/elementary/mail/releases via webinterface
Try to subscribe to https://github.com/elementary/mail/releases.atom works

System Information

News app version: 13.1.0
Nextcloud version: 15.0.5
PHP version: 7.0.33-0+deb9u1
Database and version: Postgresql 9.6.11-0+deb9u1
Browser and version: Firefox 65.0.1
Distribution and version: elementaryOS 5 (client) / Debian 9.8 (server)

Contents of nextcloud/data/nextcloud.log

{"reqId":"Av12XzODHxdgTABE3sj8","level":3,"time":"2019-03-11T13:51:56+00:00","remoteAddr":"92.193.253.167","user":"haeckle","app":"index","method":"POST","url":"/apps/news/feeds","message":{"Exception":"FeedIo\\Reader\\ReadErrorException","Message":"InvalidArgumentException: malformed xml string. parsing error : DOMDocument::loadXML(): Specification mandate value for attribute data-pjax-transient in Entity, line: 38 (2) in /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader/Document.php:104\nStack trace:\n#0 [internal function]: FeedIo\\Reader\\Document->FeedIo\\Reader\\{closure}(2, 'DOMDocument::lo...', '/var/www/nextcl...', 109, Array)\n#1 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader/Document.php(109): DOMDocument->loadXML('<!DOCTYPE html>...')\n#2 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader/Document.php(71): FeedIo\\Reader\\Document->loadDomDocument()\n#3 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Standard/Atom.php(54): FeedIo\\Reader\\Document->getDOMDocument()\n#4 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader.php(167): FeedIo\\Standard\\Atom->canHandle(Object(FeedIo\\Reader\\Document))\n#5 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader.php(153): FeedIo\\Reader->getAccurateParser(Object(FeedIo\\Reader\\Document))\n#6 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader.php(138): FeedIo\\Reader->parseDocument(Object(FeedIo\\Reader\\Document), Object(FeedIo\\Feed))\n#7 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader.php(117): FeedIo\\Reader->handleResponse(Object(FeedIo\\Adapter\\Guzzle\\Response), Object(FeedIo\\Feed))\n#8 /var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/FeedIo.php(286): FeedIo\\Reader->read('https://github....', Object(FeedIo\\Feed), Object(DateTime))\n#9 /var/www/nextcloud/apps/news/lib/Fetcher/FeedFetcher.php(73): FeedIo\\FeedIo->read('https://github....')\n#10 /var/www/nextcloud/apps/news/lib/Fetcher/Fetcher.php(66): OCA\\News\\Fetcher\\FeedFetcher->fetch('https://github....', true, NULL, NULL, NULL)\n#11 /var/www/nextcloud/apps/news/lib/Service/FeedService.php(116): OCA\\News\\Fetcher\\Fetcher->fetch('https://github....', true, NULL, NULL, NULL)\n#12 /var/www/nextcloud/apps/news/lib/Controller/FeedController.php(157): OCA\\News\\Service\\FeedService->create('https://github....', 8, 'haeckle', NULL, NULL, NULL)\n#13 /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php(166): OCA\\News\\Controller\\FeedController->create('https://github....', 8, NULL, NULL, NULL)\n#14 /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php(99): OC\\AppFramework\\Http\\Dispatcher->executeController(Object(OCA\\News\\Controller\\FeedController), 'create')\n#15 /var/www/nextcloud/lib/private/AppFramework/App.php(118): OC\\AppFramework\\Http\\Dispatcher->dispatch(Object(OCA\\News\\Controller\\FeedController), 'create')\n#16 /var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php(47): OC\\AppFramework\\App::main('OCA\\\\News\\\\Contro...', 'create', Object(OC\\AppFramework\\DependencyInjection\\DIContainer), Array)\n#17 [internal function]: OC\\AppFramework\\Routing\\RouteActionHandler->__invoke(Array)\n#18 /var/www/nextcloud/lib/private/Route/Router.php(297): call_user_func(Object(OC\\AppFramework\\Routing\\RouteActionHandler), Array)\n#19 /var/www/nextcloud/lib/base.php(987): OC\\Route\\Router->match('/apps/news/feed...')\n#20 /var/www/nextcloud/index.php(42): OC::handleRequest()\n#21 {main}","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/FeedIo.php","line":286,"function":"read","class":"FeedIo\\Reader","type":"->","args":["https://github.com/elementary/mail/releases",{"__class__":"FeedIo\\Feed"},{"date":"1970-01-01 00:00:00.000000","timezone_type":1,"timezone":"+00:00","__class__":"DateTime"}]},{"file":"/var/www/nextcloud/apps/news/lib/Fetcher/FeedFetcher.php","line":73,"function":"read","class":"FeedIo\\FeedIo","type":"->","args":["https://github.com/elementary/mail/releases"]},{"file":"/var/www/nextcloud/apps/news/lib/Fetcher/Fetcher.php","line":66,"function":"fetch","class":"OCA\\News\\Fetcher\\FeedFetcher","type":"->","args":["https://github.com/elementary/mail/releases",true,null,null,null]},{"file":"/var/www/nextcloud/apps/news/lib/Service/FeedService.php","line":116,"function":"fetch","class":"OCA\\News\\Fetcher\\Fetcher","type":"->","args":["https://github.com/elementary/mail/releases",true,null,null,null]},{"file":"/var/www/nextcloud/apps/news/lib/Controller/FeedController.php","line":157,"function":"create","class":"OCA\\News\\Service\\FeedService","type":"->","args":["https://github.com/elementary/mail/releases",8,"haeckle",null,null,null]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":166,"function":"create","class":"OCA\\News\\Controller\\FeedController","type":"->","args":["https://github.com/elementary/mail/releases",8,null,null,null]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\News\\Controller\\FeedController"},"create"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":118,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\News\\Controller\\FeedController"},"create"]},{"file":"/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\News\\Controller\\FeedController","create",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"news.feed.create"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"_route":"news.feed.create"}]},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"_route":"news.feed.create"}]},{"file":"/var/www/nextcloud/lib/base.php","line":987,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/news/feeds"]},{"file":"/var/www/nextcloud/index.php","line":42,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/nextcloud/apps/news/vendor/debril/feed-io/src/FeedIo/Reader.php","Line":122,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0","version":"15.0.5.3","id":"5c8667fd4b952"}

Contents of Browser Error Console

Read http://ggnome.com/wiki/Using_The_Browser_Error_Console if you are unsure what to put here


TypeError: "can't convert undefined to object"
	publishAll Publisher.js:34
	createFeed NavigationController.js:178
d6Angular Possibly unhandled rejection: {} angular.min.js:127
i8Angular

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Grotax · 2019-03-12T12:25:08Z

Grotax
Mar 12, 2019
Maintainer

Quick question: did this work in 13.0.3?

0 replies

tinloaf · 2019-03-12T12:51:11Z

tinloaf
Mar 12, 2019

Coming over from #412 , since some of my feeds may be affected by this, too. I can confirm that ~one week ago (was that still 13.0.3? Didn't pay attention to version numbers…) all my feeds still updated fine.

How can I confirm whether my feed update troubles are related to autodiscovery not working (as opposed to the last-modified problem)?

0 replies

Grotax · 2019-03-12T12:56:58Z

Grotax
Mar 12, 2019
Maintainer

Take the feed URL and open it in a browser.
A: A normal website with some feed URL somewhere (maybe hidden) -> affected by this
B: you get a XML document atom/RSS -> not affected by this

0 replies

tinloaf · 2019-03-12T13:01:20Z

tinloaf
Mar 12, 2019

Okay, I get that. However, autodiscovery seems to be working fine for me, at least with manual updates. Cron-based updates are still broken for all feeds, which I assume is because of #412.

Here's what happens if I do
sudo -u www-data php7.2 -f /var/www/html/nextcloud/occ news:updater:update-feed 13 tinloaf
that feed 13 points to https://nextcloud.com/news/:

MariaDB [nextcloud]> select id,url from oc_news_feeds;
+----+------------------------------------------------------------------------------------------+
| id | url                                                                                      |
+----+------------------------------------------------------------------------------------------+
[…]
| 13 | https://nextcloud.com/news/                                                              |
[…]
+----+------------------------------------------------------------------------------------------+

The complete log output is at https://privatebin.net/?caa522f5134dccf2#raRdJY+LavbQDXKqLgofwIaTBjT/ircauzXlGplgjK8=

This looks very much like auto discovery is working, right? I just tried with two more feeds which do not directly point at an RSS document, both work when I manually update them.

0 replies

SMillerDev · 2019-03-12T13:04:48Z

SMillerDev
Mar 12, 2019
Collaborator

Auto discovery is only an issue on initial setup, if you don't have trouble adding feeds you're not affected.

0 replies

Grotax · 2019-03-12T13:17:59Z

Grotax
Mar 12, 2019
Maintainer

Hmm when I try to subscribe to https://nextcloud.com/news/ I get an XML error.
When I subscribe to https://nextcloud.com/blogfeed which seems to be the actual feed it works.
And @tinloaf listed this feed in #412 as https://nextcloud.com/news/

So how is this supposed to work? Or what is actually broken.
If auto discovery is supposed to find the actual feed and subscribe to that (put it in the db) there shouldn't be a problem.

We might need to test this again with the next release as I'm not realy sure anymore, too many urls with too many different errors. 😀

0 replies

SMillerDev · 2019-03-12T13:30:57Z

SMillerDev
Mar 12, 2019
Collaborator

IIRC url is the url that was used to add a feed and there's a seperate field that represents the actual URL news will query.

0 replies

tinloaf · 2019-03-12T13:36:01Z

tinloaf
Mar 12, 2019

Indeed - it's the location field, and that is set to https://nextcloud.com/blog/feed/ in this case.

0 replies

Grotax · 2019-03-12T13:39:36Z

Grotax
Mar 12, 2019
Maintainer

OK alright my bad :)

0 replies

haeckle · 2019-03-12T17:24:55Z

haeckle
Mar 12, 2019
Author

Quick answer: yes Am 12. März 2019 13:25:09 MEZ schrieb Benjamin Brahmer <[email protected]>:

…

Quick question: did this work in 13.0.3?

0 replies

Grotax · 2019-04-25T14:25:28Z

Grotax
Apr 25, 2019
Maintainer

feed-io added a explorer in version 4.x I guess it would make sense to use that.

https://github.com/alexdebril/feed-io/blob/master/src/FeedIo/Explorer.php

0 replies

This comment has been hidden.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autodiscovery doesn't work #415

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 12 comments

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

This comment has been hidden.

{{title}}

Select a reply

Autodiscovery doesn't work #415

haeckle Mar 11, 2019

IMPORTANT

Explain the Problem

Steps to Reproduce

System Information

Contents of nextcloud/data/nextcloud.log

Contents of Browser Error Console

Replies: 12 comments

Grotax Mar 12, 2019 Maintainer

tinloaf Mar 12, 2019

Grotax Mar 12, 2019 Maintainer

tinloaf Mar 12, 2019

SMillerDev Mar 12, 2019 Collaborator

Grotax Mar 12, 2019 Maintainer

SMillerDev Mar 12, 2019 Collaborator

tinloaf Mar 12, 2019

Grotax Mar 12, 2019 Maintainer

haeckle Mar 12, 2019 Author

This comment has been hidden.

Grotax Apr 25, 2019 Maintainer

haeckle
Mar 11, 2019

Grotax
Mar 12, 2019
Maintainer

tinloaf
Mar 12, 2019

Grotax
Mar 12, 2019
Maintainer

tinloaf
Mar 12, 2019

SMillerDev
Mar 12, 2019
Collaborator

Grotax
Mar 12, 2019
Maintainer

SMillerDev
Mar 12, 2019
Collaborator

tinloaf
Mar 12, 2019

Grotax
Mar 12, 2019
Maintainer

haeckle
Mar 12, 2019
Author

Grotax
Apr 25, 2019
Maintainer