Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NcColorPicker] Get rid of vue-color in flavor of native picker for custom color #6096

Open
ShGKme opened this issue Sep 16, 2024 · 0 comments
Open

[NcColorPicker] Get rid of vue-color in flavor of native picker for custom color #6096

ShGKme opened this issue Sep 16, 2024 · 0 comments
Assignees
@ShGKme
Labels
discussion Need advices, opinions or ideas on this topic feature: colorpicker Related to the colorpicker component

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Sep 16, 2024

NcColorPicker is implemented on top of vue-color. The only feature we actually use from it is advanced picker. But it looks bad with its own style, even the font is serif.

This picker also is not accessible.

image

Currently, we only use it for advanced picker. But nowadays, all supported browsers have support for native color picker.

What about getting rid of vue-color in flavor of native color picker for advanced picker?

Screenshot from: nextcloud/spreed#13317 (comment)
@ShGKme ShGKme added discussion Need advices, opinions or ideas on this topic feature: colorpicker Related to the colorpicker component labels Sep 16, 2024
@ShGKme ShGKme self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
discussion Need advices, opinions or ideas on this topic feature: colorpicker Related to the colorpicker component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShGKme