Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NcActions] breaks when using right click #6064

Open
marcelklehr opened this issue Sep 9, 2024 · 4 comments
Open

[NcActions] breaks when using right click #6064

marcelklehr opened this issue Sep 9, 2024 · 4 comments
Assignees
@ShGKme
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: actions Related to the actions components

Comments

@marcelklehr
Copy link
Contributor

See nextcloud/server#46934

According to @susnux this would need fixing in here. 🙏
@ShGKme ShGKme self-assigned this Sep 9, 2024
@ShGKme ShGKme changed the title NcActionsMenu breaks when using right click [NcActions] breaks when using right click Sep 9, 2024
@ShGKme ShGKme added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: actions Related to the actions components labels Sep 9, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Sep 9, 2024

Current proposal I'd like to implement:

  1. Make "Right Click" (context menu) - a built-in feature of NcActions component rather than Nextcloud app + CSS override
  2. Add NcAction context provider as:
  • A component container
  • A composable function to apply feature to another container

@marcelklehr
Copy link
Contributor Author

marcelklehr commented Sep 9, 2024 •
edited
Loading

Cool! But that would be a new feature then, not a fix for server 28+, right?

@ShGKme
Copy link
Contributor

ShGKme commented Sep 9, 2024

Cool! But that would be a new feature then, not a fix for server 28+, right?

If the server uses this feature - this will be a fix.

@susnux
Copy link
Contributor

susnux commented Sep 9, 2024

According to susnux this would need fixing in here. 🙏

I think this was a misunderstanding, the other bug was a component issue, but this is a file app issue.
But as @ShGKme mentioned probably a nice feature also :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcelklehr @susnux @ShGKme