-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AuthRPC client inside lib/auth #44
Comments
…orageservice tests are failing. (TestStorageResourceFlow, TestStorageUploadResourceDuplicated, TestStorageDeleteJobDuplicated)
I've refactored auth and db packages and unified all the database mocks in a single one (in Now everything compiles fine with
I gave a look but I honestly I'm not 100% clear of what is happening there.. |
I do not agree with the aggregation you have done: database frontend are service specific and implements the minimal functions required by the specific associated service, the should be included with the service itself (also for better being able to add functionalities if required). Consider that these interfaces are not logically intended to wrap all used database capabilities. I agreed with your idea about separating (inside a subfolder in the service dir for ex. "auth/mock") the mock implementations but I do not see the point in dividing actual database wrapping function: it makes less readable code; less maintainable and mix functionalities absolutely non related. I would suggest restoring the previously organization and only proceed with mock separation. |
To summarise our talk about this issue today:
I'd consider renaming the file from Mocks will be placed in a mock subpackage hence for example we'll have:
|
Let's make the auth library self-contained by letting her export even the RPC Client (and avoid custom/copy-paste implementation in each package)
The text was updated successfully, but these errors were encountered: