Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(recent incidents): expand the incident user clicks on #41

Open
devfreddy opened this issue Mar 18, 2020 · 1 comment
Open

feat(recent incidents): expand the incident user clicks on #41

devfreddy opened this issue Mar 18, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@devfreddy
Copy link
Contributor

Summary

After selecting a MapLocation, the DetailPanel has a tab for Events/Violations etc.
When a user selects one it launches a stacked nerdlet RecentIncidents, currently it launches with all events collapsed.

Desired Behaviour

RecentIncidents nerdlet should expand the event the user clicked on to get there.

Possible Solution

When a user clicks on an event, we should add an identifier to the urlState that the RecentIncidents nerdlet can pull out to identify which event to expand as its opening.
@devfreddy devfreddy added enhancement New feature or request good first issue Good for newcomers labels Mar 18, 2020
@danielgolden
Copy link
Contributor

We're already passing clickedViolation, we just have no way of communicating to the <Timeline /> component which item we want to be expanded by default. An issue for this feature request exists: newrelic/nr1-community#55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devfreddy @danielgolden