-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: A database of the healthy human spinal cord morphometry in the PAM50 template space #16
Comments
@roboneuro generate pdf |
@roboneuro commands |
Hello @agahkarakuzu, here are the things you can ask me to do:
|
@roboneuro preview server status |
Can't perform this without reviewers |
@roboneuro add @mathieuboudreau as reviewer |
Can't add reviewers: There is no editor assigned yet |
@roboneuro assign @agahkarakuzu as editor |
Assigned! @agahkarakuzu is now the editor |
@roboneuro add @mathieuboudreau as reviewer |
@mathieuboudreau added to the reviewers list! |
@roboneuro preview server status |
🟢 NeuroLibre server is active (running). |
@roboneuro build book |
Requested branch/SHA does not exist for https://github.com/valosekj/PAM50-normalized-metrics-paper/ |
@roboneuro build book |
🟢 Successfully builtStatus: Success ℹ️ See details
|
@valosekj thank you so much for the submission! I started some tasks to check the status of the PDF build (succeeds, there's an issue with the template on our end, I'll revert the funny author names section) as well as the jupyter book build (in progress). I see that the GitHub action to build jupyter book is never triggered, I guess because you have not pushed to main since you added main.yml. Also, I deleted the trailing The book is built and served in the link above, but looks like figures etc. are not rendered, yet these are not captured as errors. I'll look into it and let you know. |
OK, looks like the data location and the code are functional! I was able to generate tables and figures on Binder. To render plotly outputs in Jupyter Book, you need something like the following from IPython.display import display, HTML
from plotly.offline import plot
my_table = table_demographic_characteristics(path_csv)
plot(my_table, filename = 'table1.html')
display(HTML('table1.html')) I guess the function |
Good catch! Thanks! I fixed this in spinalcordtoolbox/PAM50-normalized-metrics@192d0af and valosekj/PAM50-normalized-metrics-paper@e62f9ea. |
Okay, after the last push to main, the GitHub action has been triggered but failed on the permission issue during cloning of the https://github.com/valosekj/PAM50-normalized-metrics-paper.git/ repo, which is strange because the repo is public and the link works for me. |
Also, I do not know if this is relevant, but I specified a particular release (r20230904) during the submission, which is no longer applicable after the recent commit. |
Do you know how to include chapter headings in the left sidebar? Currently, only |
@roboneuro generate pdf |
@valosekj in single page format we would like to get rid of the sidebar as in https://rrsg2020.github.io/paper/. To do that, it takes a tiny modification. IIRC: only_build_toc_files: true Pinging @mathieuboudreau to confirm. Also in the summary PDF, looks like there are some WIP sections, can you please go through them? |
@roboneuro generate pdf |
Okay! Done in valosekj/PAM50-normalized-metrics-paper@d5459f8.
Thanks for pointing this out! The WIP sections (TODOs) are about adding a link to the interactive preprint to paper.md and content/index.ipynb. Is there already a permanent link that won't change in the future that I could use? |
@roboneuro build book |
🟢 Successfully builtStatus: Success ℹ️ See details
|
@valosekj The PDF template itself has already a link to the reproducible preprint (on the left column): https://github.com/neurolibre/preprints/blob/neurolibre.00016/neurolibre.00016/10.55458.neurolibre.00016.pdf They will resolve into DOI-formatted proper URLs upon publishing. So no need to duplicate it unless you want to. In that case the URL will be: https://preprint.neurolibre.org/10.55458/neurolibre.00016 |
@valosekj the book build succeeds and the interactive figures are now rendered, thank you!! Can you tag the code cells as described below so that they become collapsable in the jupyter book: https://jupyterbook.org/en/stable/content/metadata.html#jupyter-cell-tags Also, can you change the jupyter-book requirement version to |
Okay! Resolved in valosekj/PAM50-normalized-metrics-paper@818b217.
Done in valosekj/PAM50-normalized-metrics-paper@c24057c.
Sure! Done in valosekj/PAM50-normalized-metrics-paper@4094a08. |
@roboneuro build book |
🟢 Successfully builtStatus: Success ℹ️ See details
|
Perfect! Now I'll move this to actual review. |
@roboneuro start review |
OK, I've started the review over in openjournals/joss-reviews#17. |
Submitting author: @valosekj (Jan Valošek)
Repository: https://github.com/valosekj/PAM50-normalized-metrics-paper
Branch with paper.md (empty if default branch): main
Version: r20230904
Editor: @agahkarakuzu
Reviewers: @mathieuboudreau
Managing EiC: Agah Karakuzu
Status
Status badge code:
Author instructions
Thanks for submitting your paper to NeuroLibre @valosekj. Currently, there isn't a NeuroLibre editor assigned to your paper.
The AEiC suggestion for the handling editor is @agahkarakuzu.
@valosekj if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for NeuroLibre and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The NeuroLibre submission bot @roboneuro is here to help you find and assign reviewers and start the main review. To find out what @roboneuro can do for you type:
The text was updated successfully, but these errors were encountered: