Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SEAs #149

Closed
tkevinbest opened this issue Oct 21, 2023 · 1 comment
Closed

Support for SEAs #149

tkevinbest opened this issue Oct 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tkevinbest
Copy link
Member

Note - none of the angle calculation code would support SEAs right now. We might want to consider renaming things. For example joint.output_position is calculated just via motor angle with gear ratio. If there's an SEA in the mix, that might be misleading. I'm not sure the best way to handle this, but we can talk about it. Just wanted to get it our radar.

@tkevinbest tkevinbest added the enhancement New feature or request label Oct 21, 2023
@senthurayyappan
Copy link
Member

Yes! I named it output_position because there is another attribute called the joint_position, which is read from a joint encoder. I think this would be the extent we can go before things get too complicated. We can improve our documentation to convey this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants