Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationale for separate joints.py file? #132

Closed
tkevinbest opened this issue Oct 17, 2023 · 2 comments
Closed

Rationale for separate joints.py file? #132

tkevinbest opened this issue Oct 17, 2023 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@tkevinbest
Copy link
Member

Is there a reason to have Joints.py as a separate file instead of just including the joints class inside osl.py? I feel like anything we can do to cut down on files is a good thing.

Is there a use case for manually instantiating a joint? I see where one might want to manually instantiate an actuator, but it seems like you would always just do the osl object and only add one joint if you only wanted to make a joint.

@tkevinbest tkevinbest added the question Further information is requested label Oct 17, 2023
@senthurayyappan
Copy link
Member

The rationale behind having a separate module was to separate joint space attributes/methods (like home(), set_joint_impedance(), etc) from actuator attributes/methods. This would be a good setup when we start generalizing our library to support more motor drivers that may or may not have the same functionality as the dephy actuators.

The goal is to also move away from having the OSL class do everything.

@senthurayyappan senthurayyappan self-assigned this May 6, 2024
@senthurayyappan
Copy link
Member

I assigned myself to this issue and I'll close it when we successfully generalize various modules within our library.

@senthurayyappan senthurayyappan moved this to Projects in opensourceleg May 6, 2024
@senthurayyappan senthurayyappan moved this from Projects to In progress in opensourceleg May 24, 2024
@senthurayyappan senthurayyappan moved this from In progress to In review in opensourceleg May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

2 participants