Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermal model units undefined in thermal model update #122

Closed
tkevinbest opened this issue Oct 11, 2023 · 2 comments
Closed

Thermal model units undefined in thermal model update #122

tkevinbest opened this issue Oct 11, 2023 · 2 comments

Comments

@tkevinbest
Copy link
Member

This call to update the thermal model uses the user defined units, but the model expects the value in mA. If the user switches to A for the current units, the thermal model will be wrong.

https://github.com/neurobionics/opensourceleg/blob/68196600c69b2a4b167c1b23bfb1252f67e346be/opensourceleg/actuators.py#L382C1-L384C14
@github-actions
Copy link

Hello @tkevinbest, thank you for your interest in our work!

If this is a bug report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

@senthurayyappan
Copy link
Member

Fixed! Please checkout the dev branch [39a26c0].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@senthurayyappan @tkevinbest