From a41c281bdac292ded13e0d8e89108b6f2a6b578a Mon Sep 17 00:00:00 2001
From: Varun Sundar Rabindranath <varun@neuralmagic.com>
Date: Wed, 27 Mar 2024 20:55:18 +0000
Subject: [PATCH] fix if conditionals

---
 .github/actions/nm-github-action-benchmark/action.yml | 3 +--
 .github/workflows/nm-benchmark.yml                    | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/actions/nm-github-action-benchmark/action.yml b/.github/actions/nm-github-action-benchmark/action.yml
index bcc9f2bc6be88..d893649e15c5a 100644
--- a/.github/actions/nm-github-action-benchmark/action.yml
+++ b/.github/actions/nm-github-action-benchmark/action.yml
@@ -43,7 +43,6 @@ runs:
     # inconsistent state.
     - name: reset github pages branch
       run: |
-        echo "See if we can see the secret github token : ${{ inputs.github_token }} " 
         git update-ref refs/heads/${{ inputs.gh_pages_branch }} origin/${{ inputs.gh_pages_branch }}
       shell: bash
 
@@ -67,4 +66,4 @@ runs:
         # Add a commit comment describing what triggered the alert
         comment-on-alert: ${{ inputs.reporting_enabled == 'true' }}
         # TODO (varun): Is this a reasonable number ? 
-        max-items-in-chart: 50
\ No newline at end of file
+        max-items-in-chart: 50
diff --git a/.github/workflows/nm-benchmark.yml b/.github/workflows/nm-benchmark.yml
index 7193b1c4e3df4..18be16f0bb2d5 100644
--- a/.github/workflows/nm-benchmark.yml
+++ b/.github/workflows/nm-benchmark.yml
@@ -208,7 +208,7 @@ jobs:
 
       - name: nm-github-action-benchmark(bigger_is_better.json)
         # Absence of the file indicates that there were no "bigger_is_better" metrics
-        if: ${{ success() || failure() }} && ${{ hashFiles('downloads/bigger_is_better.json') != '' }}
+        if: (success() || failure()) && (hashFiles('downloads/bigger_is_better.json') != '')
         uses: ./.github/actions/nm-github-action-benchmark
         with:
           gh_action_benchmark_name: "bigger_is_better"
@@ -221,7 +221,7 @@ jobs:
 
       - name: nm-github-action-benchmark(smaller_is_better.json)
         # Absence of the file indicates that there were no "smaller_is_better" metrics
-        if: ${{ success() || failure() }} &&  ${{ hashFiles('downloads/smaller_is_better.json') != '' }}
+        if: (success() || failure()) && (hashFiles('downloads/smaller_is_better.json') != '')
         uses: ./.github/actions/nm-github-action-benchmark
         with:
           gh_action_benchmark_name: "smaller_is_better"
@@ -234,7 +234,7 @@ jobs:
 
       - name: nm-github-action-benchmark(observation_metrics.json)
         # Absence of the file indicates that there were no "observation" metrics
-        if: ${{ success() || failure() }} && ${{ hashFiles('downloads/observation_metrics.json') != '' }}
+        if: (success() || failure()) && (hashFiles('downloads/observation_metrics.json') != '')
         uses: ./.github/actions/nm-github-action-benchmark
         with:
           gh_action_benchmark_name: "observation_metrics"