Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a better solution than patching attributes onto nornir objects #22

Open
bytinbit opened this issue Jul 12, 2021 · 0 comments
Open

Find a better solution than patching attributes onto nornir objects #22

bytinbit opened this issue Jul 12, 2021 · 0 comments
Labels
refactor
Milestone
Release 4.0.0

Comments

@bytinbit
Copy link
Contributor

We patch attributes onto existing objects at two locations in the code:

  • napalm_ping.py: we add a destination field to every Nornir-Result.
  • result.py: we add an exception field to a nornir_result

There should be a more elegant solution to this - currently, mypy ignores this error using # type: ignore[attr-defined].
@bytinbit bytinbit added this to the Release 4.0.0 milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
Release 4.0.0
Development

No branches or pull requests
1 participant
@bytinbit