Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

reintroduce nft + symlink + windows test #907

Open
netlify-team-account-1 opened this issue Dec 21, 2021 · 4 comments
Open

reintroduce nft + symlink + windows test #907

netlify-team-account-1 opened this issue Dec 21, 2021 · 4 comments

Comments

@netlify-team-account-1
Copy link
Contributor

in #792, we were able to fix some shortcomings with Symlinks. There's still a bug on windows, and considering our build infrastructure doesn't run windows, we decided to skip that test for the time being:

'Correctly follows node_modules via symlink',
['bundler_esbuild', platform === 'win32' ? 'todo:bundler_nft' : 'bundler_nft'],

We should find out what this is caused by, and try to re-enable it.

@ehmicky
Copy link
Contributor

ehmicky commented Dec 21, 2021

Note: while our production builds (via buildbot) use Linux, a significant part of our Netlify CLI users are on Windows.

@eduardoboucas
Copy link
Member

I believe the issue in question only applies to the test suite itself, in the sense that we're using a different method for unzipping the archives to assert their contents.

So the actual functionality for end-users on Windows shouldn't be affected.

@netlify-team-account-1 can you confirm this is the case?

@ehmicky
Copy link
Contributor

ehmicky commented Dec 21, 2021

Ah ok @eduardoboucas, thanks for the precision. This makes sense!

@netlify-team-account-1
Copy link
Contributor Author

netlify-team-account-1 commented Jan 6, 2022

It's two-fold. Our test suite has problems unzipping symlinks, so we're skipping that test. This also means that the suite currently cannot verify that symlinks are correctly taken into account on windows, so the suite doesn't ensure there's no problems for end-users on Windows. Considering Symlinks are already a bit of a weird thing on windows, I'd say this uncertainty is acceptable for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants