You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 22, 2024. It is now read-only.
in #792, we were able to fix some shortcomings with Symlinks. There's still a bug on windows, and considering our build infrastructure doesn't run windows, we decided to skip that test for the time being:
I believe the issue in question only applies to the test suite itself, in the sense that we're using a different method for unzipping the archives to assert their contents.
So the actual functionality for end-users on Windows shouldn't be affected.
It's two-fold. Our test suite has problems unzipping symlinks, so we're skipping that test. This also means that the suite currently cannot verify that symlinks are correctly taken into account on windows, so the suite doesn't ensure there's no problems for end-users on Windows. Considering Symlinks are already a bit of a weird thing on windows, I'd say this uncertainty is acceptable for now.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
in #792, we were able to fix some shortcomings with Symlinks. There's still a bug on windows, and considering our build infrastructure doesn't run windows, we decided to skip that test for the time being:
zip-it-and-ship-it/tests/main.js
Lines 2257 to 2258 in f4e0aef
We should find out what this is caused by, and try to re-enable it.
The text was updated successfully, but these errors were encountered: