This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
chore!: use pure ES modules #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
Closed
ehmicky
commented
Nov 29, 2021
| @@ -37,7 +39,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@netlify/eslint-config-node": "^3.3.9", | |||
| "ava": "^2.4.0", | |||
| "ava": "^3.0.0", | |||
There was a problem hiding this comment.
Required for pure ES modules support.
ehmicky
requested review from
JGAntunes and
lukasholzer
and removed request for
JGAntunes and
lukasholzer
ehmicky
force-pushed
the
chore/pure-esm
branch
from
d294338
to
a93ec03
Compare
JGAntunes
previously approved these changes
Dec 2, 2021
ehmicky
force-pushed
the
chore/pure-esm
branch
from
a93ec03
to
cf540fc
Compare
JGAntunes
approved these changes
Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358
This switches from CommonJS to pure ES modules.
This is a breaking change, since consumers that still use CommonJS will need to use a dynamic
import()to load this module instead ofrequire(). Consumers that use pure ES modules will not need to change anything.