Netbox reverts changes made by custom script and I don't know why

[Cennepal]

I have written a custom script which doesn't give me any errors and by the output, it gets the IP-Addresses and their respective names correctly. However Netbox keeps giving me the message "Database changes have been reverted automatically" and as it says, reverts the changes. How do I even fix this? Why is it doing this?

Here's the code:

def run(self, data, commit):
        def reverse_dns_lookup(ip):
            try:
                return socket.gethostbyaddr(ip)[0]
            except socket.herror:
                return ''

        subnets = Prefix.objects.all()

        for subnet in subnets:
            self.log_info(f"Processing subnet: {subnet.prefix}")

            if subnet.status == 'reserved':
                self.log_info(f"Skipping reserved subnet: {subnet.prefix}")
                continue

            network = ipaddress.IPv4Network(subnet.prefix)
            mask = f"/{network.prefixlen}"

            for ip in network.hosts():
                ip_with_mask = f"{ip}{mask}"
                dns_name = reverse_dns_lookup(str(ip))
                is_pingable = ping(str(ip), timeout=1)

                existing_ip = IPAddress.objects.filter(address=ip_with_mask)

                if existing_ip:
                    existing_ip = IPAddress.objects.get(address=ip_with_mask)
                    if is_pingable and existing_ip.status.label != "Online":
                        existing_ip.status = 'online'
                        self.log_info(f"IP {ip} is online. Updating status.")
                    elif not is_pingable and existing_ip.status.label != "Offline":
                        existing_ip.status = 'offline'
                        self.log_info(f"IP {ip} is offline. Updating status.")
                    if dns_name:
                        if dns_name.lower() != existing_ip.dns_name.lower():
                            existing_ip.dns_name = dns_name
                            self.log_info(f"Updating DNS name for IP {ip} to {dns_name}.")
                    existing_ip.save()
                    self.log_info(f"Updated IP {ip_with_mask}.")
                elif is_pingable or dns_name:
                    status = 'online' if is_pingable else 'in dns'
                    new_ip = IPAddress(address=ip_with_mask, status=status, dns_name=dns_name)
                    new_ip.save()
                    self.log_info(f"Added new IP {ip_with_mask} with status {status}.")
                else:
                    self.log_info(f"IP {ip} is not an existing IP and is not pingable or has no DNS name.")

[zmaster7]

All scripts have a "Commit changes" checkbox at the bottom of them, it sounds like it was left unchecked when run:

[Cennepal]

What the hell? That does work, HOWEVER, it was already checked before! I just unchecked and rechecked it. God, I just wasted so many hours. Thank you.

[zmaster7]

No problem! Odd that it had already been checked before though...

On a side note, you may want to consider using .snapshot() and/or .full_clean() before calling .save() as well. See: #14718

[Cennepal]

No problem! Odd that it had already been checked before though...

On a side note, you may want to consider using .snapshot() and/or .full_clean() before calling .save() as well. See: #14718

Thanks :D