Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background images not working #5

Open
Azmodeszer opened this issue Mar 7, 2024 · 10 comments
Open

Background images not working #5

Azmodeszer opened this issue Mar 7, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@Azmodeszer
Copy link

Azmodeszer commented Mar 7, 2024

Taken from tbotnz#26

There's three inquiries/issues here...

  1. Uploading a background image for locations is giving me a Python error:

'NoneType' object has no attribute 'id'

  1. Uploading a background image for sites is going through, but there is nothing displayed in the floorplan tab. It's the usual blank canvas. I checked the actual file system, the image is there and has the needed Linux permissions. Do images have to meet certain file type and/or size requirements? The documentation didn't say (or I missed it).

  2. When adding (or updating) a floor plan through the Admin page, why is the Tags field required?

Thanks.

Python version: 3.11.2
NetBox version: 3.7.3
netbox_floorplan: 0.4

@DanSheps
Copy link
Member

DanSheps commented Mar 7, 2024

Okay, probably because I don't use floorplan right now, but how do you upload a floor plan?

LOL

@Azmodeszer
Copy link
Author

Admin > Floorplans >Select floorplan to change >Background image

@DanSheps
Copy link
Member

DanSheps commented Mar 8, 2024

I didn't have any issue with that workflow using this fork.

@helheimcloud
Copy link

Same issue here with Netbox 3.7.3. Is 3.7 unsupported? Any advise would be appreciated.

@the-root42
Copy link

Same issue for me on 3.7.4. Occurs both in my prod and test environment.

@bastianleicht
Copy link

Same issue. Has anyone a fix for that?

@jeffgdotorg
Copy link

@Azmodeszer have you managed to reproduce this problem using a freshly installed system as your starting point? I want to drive us to a fix but it appears there's some inconsistency in different people's ability to see the problem in action.

@DanSheps
Copy link
Member

DanSheps commented May 6, 2024

@Azmodeszer have you managed to reproduce this problem using a freshly installed system as your starting point? I want to drive us to a fix but it appears there's some inconsistency in different people's ability to see the problem in action.

Honestly, we should just move it to the new style admin panel. I think this is an issue with the built-in panel and the way it is leveraged

@Azmodeszer
Copy link
Author

@Azmodeszer have you managed to reproduce this problem using a freshly installed system as your starting point? I want to drive us to a fix but it appears there's some inconsistency in different people's ability to see the problem in action.

I have not tried it on a completely fresh install (yet), no. When/if I get around to it, I will post my findings.

@cruse1977
Copy link
Member

I now have the full history of this and whilst the admin panel was there, the javascript code for this was not due to scaling problems and a change in JS library.

I have a version that semi works but with mass scaling issues alongside we'd need to move the upload over to django storage this is potentially a lot of work.

@cruse1977 cruse1977 self-assigned this Jun 6, 2024
@cruse1977 cruse1977 added enhancement New feature or request wontfix This will not be worked on and removed wontfix This will not be worked on labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants