Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Mistake in comments for query_filters #1321

Open
kiltum opened this issue Sep 19, 2024 · 1 comment
Open

[Docs]: Mistake in comments for query_filters #1321

kiltum opened this issue Sep 19, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed status: accepted

Comments

@kiltum
Copy link

kiltum commented Sep 19, 2024

Change Type

Correction

Area

Configuration parameters

Proposed Changes

Look at https://docs.ansible.com/ansible/latest/collections/netbox/netbox/nb_inventory_inventory.html,

query_filters:
  - role: server
  - tag: web
  - tag: production

# See the NetBox documentation at https://netbox.readthedocs.io/en/stable/rest-api/overview/
# the query_filters work as a logical **OR**
#

But in this example they work as logical AND and will select devices, that has role server AND tag web AND tag production. But if I add

- status: active
- status: provisioning

They will use OR

Look like need more deep explain in plugin documentation, when rule OR applies, and when AND. Now looks like for role and tag always applies AND, and for other fields OR

@kiltum kiltum added the documentation Improvements or additions to documentation label Sep 19, 2024
@sc68cal sc68cal added help wanted Extra attention is needed status: accepted labels Oct 21, 2024
@sc68cal
Copy link
Contributor

sc68cal commented Oct 21, 2024

Agree, this needs more documentation. Thanks for the research and summary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed status: accepted
Projects
None yet
Development

No branches or pull requests

2 participants