Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some porchctl rpkg subcommands respond on standard error on successful executions #562

Closed
liamfallon opened this issue Mar 5, 2024 · 5 comments
Assignees
Labels
area/platform area/porch Porch related issues bug Something isn't working
Milestone

Comments

@liamfallon
Copy link
Member

Some porchctl rpkg commands respond on stderr when the command completes successfully.

The init and copy commands respond on stdout.

The pull and push commands have no response.

The propose, approve, propose-delete and delete subcommands exhibit this behaviour, see below:

porchctl rpkg propose -n porch-demo management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 > /tmp/aaa.txt
management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 proposed

porchctl rpkg approve -n porch-demo management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 > /tmp/aaa.txt
management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 approved

porchctl rpkg propose-delete -n porch-demo management-49580fc22bcf3bf51d334a00b6baa41df597219e
management-49580fc22bcf3bf51d334a00b6baa41df597219e proposed for deletion

porchctl rpkg delete -n porch-demo management-2eeaaf7c1c41c8202687da7420d2a6a1cdaba051 > /dev/null
management-2eeaaf7c1c41c8202687da7420d2a6a1cdaba051 deleted

All the subcommands of porchctl rpkg should be checked to ensure they respond on stdout in successful executions and stderr on failed executions.

@liamfallon liamfallon added bug Something isn't working area/policy area/porch Porch related issues and removed area/policy labels Mar 5, 2024
@kushnaidu
Copy link
Contributor

/assign @kushnaidu

@kushnaidu
Copy link
Contributor

Hello @liamfallon,
the code is merged.
Can we close this ticket?

@liamfallon
Copy link
Member Author

I saw that you will riase a PR to do unit tests for the changed commands. Let's wait for that before closing the issue.

@kushnaidu
Copy link
Contributor

@liamfallon, perfect. Will do that.

@liamfallon
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from Todo to Done in R4 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform area/porch Porch related issues bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants