We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some porchctl rpkg commands respond on stderr when the command completes successfully.
porchctl rpkg
The init and copy commands respond on stdout.
init
copy
The pull and push commands have no response.
pull
push
The propose, approve, propose-delete and delete subcommands exhibit this behaviour, see below:
propose
approve
propose-delete
delete
porchctl rpkg propose -n porch-demo management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 > /tmp/aaa.txt management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 proposed porchctl rpkg approve -n porch-demo management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 > /tmp/aaa.txt management-8b80738a6e0707e3718ae1db3668d0b8ca3f1c82 approved porchctl rpkg propose-delete -n porch-demo management-49580fc22bcf3bf51d334a00b6baa41df597219e management-49580fc22bcf3bf51d334a00b6baa41df597219e proposed for deletion porchctl rpkg delete -n porch-demo management-2eeaaf7c1c41c8202687da7420d2a6a1cdaba051 > /dev/null management-2eeaaf7c1c41c8202687da7420d2a6a1cdaba051 deleted
All the subcommands of porchctl rpkg should be checked to ensure they respond on stdout in successful executions and stderr on failed executions.
The text was updated successfully, but these errors were encountered:
/assign @kushnaidu
Sorry, something went wrong.
Hello @liamfallon, the code is merged. Can we close this ticket?
I saw that you will riase a PR to do unit tests for the changed commands. Let's wait for that before closing the issue.
@liamfallon, perfect. Will do that.
Fixed in: nephio-project/porch#30 nephio-project/porch#33
kushnaidu
No branches or pull requests
Some
porchctl rpkg
commands respond on stderr when the command completes successfully.The
init
andcopy
commands respond on stdout.The
pull
andpush
commands have no response.The
propose
,approve
,propose-delete
anddelete
subcommands exhibit this behaviour, see below:All the subcommands of
porchctl rpkg
should be checked to ensure they respond on stdout in successful executions and stderr on failed executions.The text was updated successfully, but these errors were encountered: