Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neonvm-controller does not update VM status if reconcile fails #889

Open
sharnoff opened this issue Apr 2, 2024 · 0 comments · May be fixed by #1103
Open

neonvm-controller does not update VM status if reconcile fails #889

sharnoff opened this issue Apr 2, 2024 · 0 comments · May be fixed by #1103
Labels
c/autoscaling/neonvm Component: autoscaling: NeonVM

Comments

@sharnoff
Copy link
Member

sharnoff commented Apr 2, 2024

Problem description / Motivation

Maybe this is the desired behavior, however: Currently, if reconciling fails, the neonvm-controller does not update the VM status, even if it has changed.

This means that it's possible for more up-to-date status information to be arbitrarily delayed due to reconcile failures (either due to transient issues or bugs).

I think this is probably not desirable as it impacts liveness, and as we move towards greater dependence on what's reported by the controller, we may want to tighten this up.

Feature idea(s) / DoD

Don't skip status update if there was some earlier failure.
@sharnoff sharnoff added the c/autoscaling/neonvm Component: autoscaling: NeonVM label Apr 2, 2024
agadelshin added a commit to agadelshin/autoscaling that referenced this issue Jul 14, 2024
@agadelshin
neonvm-controller: patch status if reconcile fails (neondatabase#889)
929d943
agadelshin added a commit to agadelshin/autoscaling that referenced this issue Jul 22, 2024
@agadelshin
neonvm-controller: patch status if reconcile fails (neondatabase#889)
c2496f1
agadelshin added a commit to agadelshin/autoscaling that referenced this issue Jul 22, 2024
@agadelshin
neonvm-controller: patch status if reconcile fails (neondatabase#889)
3bf2d00
sharnoff added a commit that referenced this issue Oct 10, 2024
@sharnoff @agadelshin
neonvm-controller: Patch status even if reconcile fails
f017c80 
Fixes #889.

Co-authored-by: Artur Gadelshin <[email protected]>
@sharnoff sharnoff linked a pull request Oct 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/autoscaling/neonvm Component: autoscaling: NeonVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

neonvm-controller: Patch status even if reconcile fails neondatabase/autoscaling
1 participant
@sharnoff