Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grammar] its not possible to specify no regex for comments or eol_comments #303

Closed
apalala opened this issue Aug 26, 2023 · 3 comments
Closed

[grammar] its not possible to specify no regex for comments or eol_comments #303

apalala opened this issue Aug 26, 2023 · 3 comments

Comments

@apalala
Copy link
Collaborator

apalala commented Aug 26, 2023

In this case // is a valid regex that matches nothing. We should be able to filter for False, or None, or ().
@apalala
Copy link
Collaborator Author

apalala commented Oct 13, 2023

This issue needs a unit test. Also, make sure that the default for comments in tokenizers is None.

@apalala
Copy link
Collaborator Author

apalala commented Oct 13, 2023

Checked the above, and inform.ParserConfig.comments_re defaults to the value of the grammar for TatSu grammars.

@apalala
Copy link
Collaborator Author

apalala commented Oct 13, 2023

This is solved by #314

@apalala apalala closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apalala