Prevent mods from modifying the mod list #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 0ac9cedc81ff70fc9f0190cab8853212da16752d. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #235' // https://github.com/neoforged/FancyModLoader/pull/235
url 'https://prmaven.neoforged.net/FancyModLoader/pr235'
content {
includeModule('net.neoforged.fancymodloader', 'earlydisplay')
includeModule('net.neoforged.fancymodloader', 'junit-fml')
includeModule('net.neoforged.fancymodloader', 'loader')
includeModule('net.neoforged.fancymodloader', 'tests')
}
}
} |
|
@embeddedt, this PR introduces breaking changes. Compatibility checks
|
| this.fileById = this.modFiles.stream().map(IModFileInfo::getMods).flatMap(Collection::stream).map(ModInfo.class::cast).collect(Collectors.toMap(ModInfo::getModId, ModInfo::getOwningFile)); | ||
| this.modFiles = modFiles.stream().map(ModFile::getModFileInfo).toList(); | ||
| this.sortedList = sortedList.stream().map(IModInfo.class::cast).toList(); | ||
| this.fileById = Collections.unmodifiableMap(this.modFiles.stream().map(IModFileInfo::getMods).flatMap(Collection::stream).map(ModInfo.class::cast).collect(Collectors.toMap(ModInfo::getModId, ModInfo::getOwningFile))); |
There was a problem hiding this comment.
You could also use Collectors#toUnmodifiableMap
|
@embeddedt Are you intending this to go into any current version? Otherwise, I'd rather just handle this in startup experiments (and I agree with the change). |
|
It would be ideal to get it in 1.21.1 at least (which implies it needs to be in 1.21.4, due to the backporting policy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically guaranteed to cause unexpected/difficult to debug behavior if someone tries it (accidentally or otherwise).