You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we experience e.g. a constraint validation failure, we're getting Neo4j::Driver::Exceptions::ClientException instead of the expected error class, ActiveGraph::Core::SchemaErrors::ConstraintValidationFailedError.
Upon digging deeper, it appears to me that the ActiveGraph::Core::SchemaErrors::CypherError family of exceptions are completely unused. The API to convert from Neo4j driver errors to ActiveGraph errors is present, but never called. The specs only test the ActiveGraph::Core::SchemaErrors::CypherError API as far as I can see, but not that the conversion ever actually takes place.
The text was updated successfully, but these errors were encountered:
@klobuczek I may be wrong about my assessment here. Let me know. In any case, I am happy to submit a PR to fix this if you can give me some guidance on where I should fix (base.rb? transaction.rb? transactions.rb?)
When we experience e.g. a constraint validation failure, we're getting
Neo4j::Driver::Exceptions::ClientException
instead of the expected error class,ActiveGraph::Core::SchemaErrors::ConstraintValidationFailedError
.Upon digging deeper, it appears to me that the
ActiveGraph::Core::SchemaErrors::CypherError
family of exceptions are completely unused. The API to convert from Neo4j driver errors to ActiveGraph errors is present, but never called. The specs only test theActiveGraph::Core::SchemaErrors::CypherError
API as far as I can see, but not that the conversion ever actually takes place.The text was updated successfully, but these errors were encountered: