Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications added via symbolic link path don't get processed by HidHide #128

Open
velocity7 opened this issue Dec 1, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@velocity7
Copy link

velocity7 commented Dec 1, 2023

Bug description

If you add an application path that is passed in via symbolic link, HidHide will not process it and it doesn't get filtered out properly (e.g., cannot hide/unhide devices depending on blacklist/whitelist).

Steps to reproduce

  • Confirm that you can add an application to HidHide and it tests properly with filtering.
  • Create a symbolic link to the application using mklink, Link Shell Extension, etc.
  • Remove the application from the list, then add it using the symbolic link.

Actual result: Only adding the application directly as opposed to symbolic link works.
Expected result: Symbolic link should work.

Screenshots

N/A

Machine info

N/A

Any other helpful information

Symbolic link bug appears to have been mentioned in ticket #99 but wasn't officially submitted as a ticket.

@nefarius nefarius added the bug Something isn't working label Dec 1, 2023
@DAOWAce
Copy link

DAOWAce commented May 31, 2024

..well that explains a lot.

Couldn't get controller working with DS4Windows again after testing stuff on a separate OS install.

Adding the root path, and launching DS4Windows from said path instead of the symlink, made it register again.

Symlinks causing yet another super niche issue with a program.. sigh.

@masterflitzer
Copy link
Contributor

just for clarification so i don't run myselft into the problem, are symlinks and shortcuts (.lnk) affected or only one of them or do shortcuts not even work?

@nefarius
Copy link
Owner

nefarius commented Jun 28, 2024

just for clarification so i don't run myselft into the problem, are symlinks and shortcuts (.lnk) affected or only one of them or do shortcuts not even work?

A shortcut (.lnk) and a symbolic link are two different worlds, symbolic links are mount points where within the directory tree some folder might actually point to a different disk.

Most users do not make use of symbolic links outside of advanced setups.

@nefarius
Copy link
Owner

Symlinks causing yet another super niche issue with a program.. sigh.

Which DS4Windows edition and version? If it uses my official Nefarius.Drivers.HidHide implementation, it should take symlinks into account correctly. Otherwise if they do some custom implementation, the fault might lie there. Symlinks have to be resolved by the app that configures HidHide since the driver itself only sees "real" disks.

@DAOWAce
Copy link

DAOWAce commented Jun 30, 2024

Which DS4Windows edition and version?

Ryochan's DS4Windows, v3.3.3 x64

Wasn't aware there was another version. Did someone else take up the mantle?

@nefarius
Copy link
Owner

Which DS4Windows edition and version?

Ryochan's DS4Windows, v3.3.3 x64

Wasn't aware there was another version. Did someone else take up the mantle?

I am asking because people tend to fall for scam sites that offer them a 6 year old build as the hot stuff, just to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants