Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notification along with sound #16

Open
il3ven opened this issue May 18, 2021 · 2 comments
Open

Show notification along with sound #16

il3ven opened this issue May 18, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@il3ven
Copy link

il3ven commented May 18, 2021

Is your feature request related to a problem? Please describe.
It is possible that laptop is on mute and I am not able to hear the alert.

Describe the solution you'd like
A notification through the browser will solve the problem.

Describe alternatives you've considered
None

Additional context
None

I can open a simple PR for this. The idea is to ask for notification permission on load. Modify the play function to show notification along with playing a sound.
@neelpy
Copy link
Owner

neelpy commented May 18, 2021

Please add a PR for this

@neelpy neelpy added enhancement New feature or request help wanted Extra attention is needed labels May 18, 2021
@Nikhil27b Nikhil27b mentioned this issue May 19, 2021
Closed
@Nikhil27b
Copy link
Contributor

Solved #20

@il3ven il3ven mentioned this issue May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notification Added Nikhil27b/cowin
Added notification toggle
3 participants
@il3ven @neelpy @Nikhil27b