Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tla-account character upper limit to >=65? #18

Closed
ghost opened this issue Nov 6, 2023 · 1 comment
Closed

Increase tla-account character upper limit to >=65? #18

ghost opened this issue Nov 6, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 6, 2023

Issue

The stabilization of nep492 made it only that the "registrar" can create accounts with characters <65. The account-id limit is set at 64.

pub const MAX_LEN: usize = 64;

This is a little urgent as sandbox @1.36.0 with workspaces fail. The simple fix would be to change the configuration like so: https://github.com/shariffdev/nearcore/commit/fba184790fab198a42fee06482b45ff66f709dd4. We could make an exception and go for this although there's a comment against it on my first try which is still relevant.

This is also a departure from how sandbox functionality changes have been implemented in the past, which is feature gating specific areas of the implementation, rather than configuration.

Also if we tweak the config it will be a gotcha for devs after using workspaces.

Possible solution

Come up with a set of different character limits. Perhaps, split the generalization and have implicit accounts remain at 64 while top-level accounts can be at >=65. This route would affect near-sdk-rs and (maybe) other places...

Or brainstorm a better/cleaner strategy.

Cc @frol @ChaoticTempest

@frol
Copy link
Collaborator

frol commented Nov 6, 2023

while top-level accounts can be at >=65.

Since the account-id length requirement has not changed, that update in the config to >=65 effectively means that no top-level is allowed to be created without a registrar.

There are no actions needed to be taken in near-account-id.

near-workspaces-rs has to stop relying on top-level accounts and use subaccounts by default (just like most of the account on NEAR mainnet are subaccounts of near account, and on testnet - testnet is the top-level account)

@frol frol closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant