Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong seat price computation with stateless validation feature enabled #11

Open
telezhnaya opened this issue Mar 6, 2024 · 0 comments · May be fixed by #12
Open

Wrong seat price computation with stateless validation feature enabled #11

telezhnaya opened this issue Mar 6, 2024 · 0 comments · May be fixed by #12

Comments

@telezhnaya
Copy link

My validator on StatelessNet is shown as the one to be kicked off for more than a week, while I'm successfully validating all this week.

More info here
https://near.zulipchat.com/#narrow/stream/407237-core.2Fstateless-validation/topic/Wrong.20seats.20number/near/424915436

We need to change the logic for max_number_of_seats
https://github.com/near-cli-rs/near-validator-cli-rs/blob/main/src/proposals/mod.rs#L136
https://github.com/near-cli-rs/near-validator-cli-rs/blob/main/src/validators/block_id/mod.rs#L86
(maybe somewhere else)

It surely should take into account protocol_config. num_chunk_only_producer_seats. But I'm still not sure about the resulting formula. Let's wait for the updates on Zulip and then we can create a fix for this.

@telezhnaya telezhnaya linked a pull request Mar 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant