Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting logit_model_nonprobsvy and others #65

Open
BERENZ opened this issue Jan 16, 2025 · 5 comments
Open

Exporting logit_model_nonprobsvy and others #65

BERENZ opened this issue Jan 16, 2025 · 5 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@BERENZ
Copy link
Contributor

BERENZ commented Jan 16, 2025

Shall we export logit_model_nonprobsvy, probit_model_nonprobsvy, cloglog_model_nonprobsvy and pop.size functions?

@BERENZ BERENZ added the help wanted Extra attention is needed label Jan 16, 2025
@Kertoo
Copy link
Member

Kertoo commented Jan 16, 2025

pop.size should be exported (and renamed to pop_size) but the rest are meant to be internal functions

@BERENZ
Copy link
Contributor Author

BERENZ commented Jan 16, 2025

OK. Regarding the naming shall we apply this to controlInf (control_inf), controlOut (control_out), controlSel (control_sel) and genSimData (gen_sim_data)? I imagine that changing this may cause problems but maybe this is the right time (before CRAN submission)? This should be reported as a breaking change in the NEWS file. What do you think @LukaszChrostowski ?

@LukaszChrostowski
Copy link
Member

Hmm, yes, we should be consistent here

@LukaszChrostowski
Copy link
Member

Regarding logit_model_nonprobsvy, the reason of exporting this is usage that 'internal' function in Cpp implementation of variables selection algorithms, without exporting - the Cpp file can not see it, my solution looks naively a bit, so let me find something better, maybe you @Kertoo have any ideas?

@BERENZ
Copy link
Contributor Author

BERENZ commented Jan 27, 2025

@bschneidr maybe you could provide some suggestions regarding this issue? Currently, the function logit_model_nonprobsvy is exported so Rcpp can be used for the variable selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants