-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lumen 8 compatibility #23
Comments
Confirming this issue is present. ErrorException
Declaration of Nbj\Cockroach\Grammar\Query\CockroachGrammar::compileUpdateColumns($values) should be compatible with Illuminate\Database\Query\Grammars\Grammar::compileUpdateColumns(Illuminate\Database\Query\Builder $query, array $values)
at C:\Users\elyci\PhpstormProjects\project\vendor\nbj\cockroachdb-laravel\src\Cockroach\Grammar\Query\CockroachGrammar.php:127
123▕ *
124▕ * @param array $values
125▕ * @return string
126▕ */
➜ 127▕ protected function compileUpdateColumns($values)
128▕ {
129▕ // When gathering the columns for an update statement, we'll wrap each of the
130▕ // columns and convert it to a parameter value. Then we will concatenate a
131▕ // list of the columns that can be added into this update query clauses. I'll see if I can open a PR for this. |
This appears to be in master with 626613a - so probably could be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested on Lumen version 7 & 8
Following error is thrown:
Declaration of Nbj\Cockroach\Grammar\Query\CockroachGrammar::compileUpdateColumns($values) must be compatible with Illuminate\Database\Query\Grammars\Grammar::compileUpdateColumns(Illuminate\Database\Query\Builder $query, array $values)
This can be fixed by changing the prototype of the method.
The text was updated successfully, but these errors were encountered: